Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Covid Research module and related code #18780

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

@acrollet acrollet added the NOT_YET Don't merge this PR w/o the authors permission label Oct 7, 2024
@acrollet acrollet changed the title Remove module and related code Remove Covid Research module and related code Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

1 Error
🚫 This PR changes 1274 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • .github/CODEOWNERS (+0/-1)

  • .rubocop_todo.yml (+0/-10)

  • Gemfile (+0/-1)

  • config/features.yml (+0/-12)

  • config/routes.rb (+0/-1)

  • config/settings.yml (+0/-5)

  • modules/covid_research/Gemfile (+0/-3)

  • modules/covid_research/app/controllers/covid_research/application_controller.rb (+0/-15)

  • modules/covid_research/app/controllers/covid_research/base_controller.rb (+0/-12)

  • modules/covid_research/app/controllers/covid_research/volunteer/submissions_controller.rb (+0/-56)

  • modules/covid_research/app/jobs/covid_research/application_job.rb (+0/-4)

  • modules/covid_research/app/mailers/covid_research/volunteer/submission_mailer.rb (+0/-24)

  • modules/covid_research/app/models/covid_research/application_record.rb (+0/-5)

  • modules/covid_research/app/serializers/covid_research/genisis_serializer.rb (+0/-57)

  • modules/covid_research/app/serializers/covid_research/volunteer/facility_serializer.rb (+0/-22)

  • modules/covid_research/app/serializers/covid_research/volunteer/name_serializer.rb (+0/-27)

  • modules/covid_research/app/services/covid_research/volunteer/form_crypto_service.rb (+0/-18)

  • modules/covid_research/app/services/covid_research/volunteer/form_service.rb (+0/-57)

  • modules/covid_research/app/services/covid_research/volunteer/genisis_service.rb (+0/-44)

  • modules/covid_research/app/sidekiq/covid_research/volunteer/confirmation_mailer_job.rb (+0/-10)

  • modules/covid_research/app/sidekiq/covid_research/volunteer/genisis_delivery_job.rb (+0/-35)

  • modules/covid_research/app/views/covid_research/volunteer/signup_confirmation.html.erb (+0/-32)

  • modules/covid_research/app/views/covid_research/volunteer/update_confirmation.html.erb (+0/-33)

  • modules/covid_research/bin/rails (+0/-15)

  • modules/covid_research/config/routes.rb (+0/-6)

  • modules/covid_research/covid_research.gemspec (+0/-18)

  • modules/covid_research/lib/covid_research.rb (+0/-4)

  • modules/covid_research/lib/covid_research/engine.rb (+0/-6)

  • modules/covid_research/lib/covid_research/version.rb (+0/-3)

  • modules/covid_research/lib/redis_format.rb (+0/-31)

  • modules/covid_research/lib/tasks/covid_research_tasks.rake (+0/-20)

  • modules/covid_research/restclient/.gitignore (+0/-1)

  • modules/covid_research/restclient/genisis.http (+0/-4)

  • modules/covid_research/spec/covid_research_spec_helper.rb (+0/-9)

  • modules/covid_research/spec/mailers/covid_research/volunteer/submission_mailer_spec.rb (+0/-31)

  • modules/covid_research/spec/rails_helper.rb (+0/-3)

  • modules/covid_research/spec/redis_format_spec.rb (+0/-51)

  • modules/covid_research/spec/requests/covid_research/volunteer_spec.rb (+0/-135)

  • modules/covid_research/spec/serializers/covid_research/genisis_serializer_spec.rb (+0/-59)

  • modules/covid_research/spec/serializers/covid_research/volunteer/facility_serializer_spec.rb (+0/-17)

  • modules/covid_research/spec/serializers/covid_research/volunteer/name_serializer_spec.rb (+0/-24)

  • modules/covid_research/spec/services/covid_research/volunteer/form_crypto_service_spec.rb (+0/-31)

  • modules/covid_research/spec/services/covid_research/volunteer/form_service_intake_spec.rb (+0/-91)

  • modules/covid_research/spec/services/covid_research/volunteer/form_service_update_spec.rb (+0/-59)

  • modules/covid_research/spec/services/covid_research/volunteer/genisis_service_spec.rb (+0/-105)

  • modules/covid_research/spec/sidekiq/covid_research/volunteer/confirmation_mailer_job_spec.rb (+0/-23)

  • modules/covid_research/spec/sidekiq/covid_research/volunteer/genisis_delivery_job_spec.rb (+0/-39)

  • modules/covid_research/spec/spec_helper.rb (+0/-5)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to chore/remove-coronavirus_research-module/main/main October 7, 2024 22:24 Inactive
@acrollet acrollet removed the NOT_YET Don't merge this PR w/o the authors permission label Oct 8, 2024
@acrollet acrollet marked this pull request as ready for review October 8, 2024 17:48
@acrollet acrollet requested review from a team as code owners October 8, 2024 17:48
@RachalCassity
Copy link
Member

FYI. Please remove the 4 flippers, in the rails console for each environment, after the PR is merged.
Flipper.remove(: covid_volunteer_intake_backend_enabled)

@RachalCassity
Copy link
Member

The codeowners file has errors that should go away if you merge from master.

@LindseySaari
Copy link
Contributor

Are there any synthetics that hit any of the covid endpoints? Just thinking of things that might break when removing this

Copy link

github-actions bot commented Oct 9, 2024

Backend-review-group approval confirmed.

@LindseySaari
Copy link
Contributor

@s-caso Approved! Can you confirm if any of these Github teams associated with code ownership need to be deleted? Thanks!

@acrollet
Copy link
Contributor Author

acrollet commented Oct 9, 2024

thanks @LindseySaari ! I've reached out to @karlbrown-va on Slack to ask about the long-covid team. btw the backend review check is not passing...

@acrollet
Copy link
Contributor Author

acrollet commented Oct 9, 2024

update: @karlbrown-va confirmed that long-covid team is still in use.

@acrollet
Copy link
Contributor Author

acrollet commented Oct 9, 2024

Update 2: @karlbrown-va confirmed that this PR is ok from that team's perspective, and asked that any remaining long-covid references be removed from vets-api (which I'll do in a separate pr)

Copy link
Contributor

@karlbrown-va karlbrown-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine from my side, I confirmed the current team isn't using this feature.

@acrollet
Copy link
Contributor Author

@LindseySaari would you be able to re-approve or would you like me to go through platform support? thanks!

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 15, 2024
@acrollet acrollet removed the Stale label Nov 18, 2024
@acrollet
Copy link
Contributor Author

@LindseySaari re-pinging 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants