-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Covid Research module and related code #18780
base: master
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
FYI. Please remove the 4 flippers, in the rails console for each environment, after the PR is merged. |
The codeowners file has errors that should go away if you merge from master. |
Are there any synthetics that hit any of the covid endpoints? Just thinking of things that might break when removing this |
Backend-review-group approval confirmed. |
@s-caso Approved! Can you confirm if any of these Github teams associated with code ownership need to be deleted? Thanks! |
thanks @LindseySaari ! I've reached out to @karlbrown-va on Slack to ask about the long-covid team. btw the backend review check is not passing... |
update: @karlbrown-va confirmed that long-covid team is still in use. |
Update 2: @karlbrown-va confirmed that this PR is ok from that team's perspective, and asked that any remaining long-covid references be removed from vets-api (which I'll do in a separate pr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine from my side, I confirmed the current team isn't using this feature.
@LindseySaari would you be able to re-approve or would you like me to go through platform support? thanks! |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
@LindseySaari re-pinging 🙂 |
Summary
Related issue(s)
department-of-veterans-affairs/va.gov-team#83785