Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update component library #32286

Merged
merged 7 commits into from
Oct 7, 2024
Merged

update component library #32286

merged 7 commits into from
Oct 7, 2024

Conversation

micahchiang
Copy link
Contributor

@micahchiang micahchiang commented Oct 7, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Updates component-library and css-library. Release notes

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce)
  • (What is the solution, why is this the solution)
  • (Which team do you work for, does your team own the maintenance of this component?)
  • (If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

  • Link to ticket created in va.gov-team repo
    department-of-veterans-affairs/va.gov-team#0000
  • Link to previous change of the code/bug (if applicable)
    department-of-veterans-affairs/vets-website#0000
  • Link to epic if not included in ticket
    department-of-veterans-affairs/va.gov-team#0000

Testing done

  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected
  • Describe the tests completed and the results
  • _Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
  • Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@micahchiang micahchiang requested a review from a team as a code owner October 7, 2024 15:40
@va-vfs-bot va-vfs-bot temporarily deployed to master/mc-comp-lib-47.1.0/main October 7, 2024 15:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/mc-comp-lib-47.1.0/main October 7, 2024 17:04 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@micahchiang micahchiang requested a review from a team as a code owner October 7, 2024 17:34
@va-vfs-bot va-vfs-bot temporarily deployed to master/mc-comp-lib-47.1.0/main October 7, 2024 17:43 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.

Note:

Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon

className="fas fa-arrow-down vads-u-padding-right--1 vads-u-font-size--sm"
/>
<span className="vads-u-padding-right--1 vads-u-font-size--sm">
<va-icon icon="arrow_downward" size={3} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon found

@va-vfs-bot va-vfs-bot temporarily deployed to master/mc-comp-lib-47.1.0/main October 7, 2024 18:47 Inactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screener app still exists in the registry so we can't get rid of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah my bad, I'll put it back.

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@micahchiang micahchiang requested a review from acrollet October 7, 2024 19:08
pjhill
pjhill previously approved these changes Oct 7, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/mc-comp-lib-47.1.0/main October 7, 2024 19:17 Inactive
acrollet
acrollet previously approved these changes Oct 7, 2024
Copy link
Contributor

@acrollet acrollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coronavirus-research changes approved, the entryNames in the two removed manifests match those in https://github.com/department-of-veterans-affairs/content-build/pull/2302/files

@va-vfs-bot va-vfs-bot temporarily deployed to master/mc-comp-lib-47.1.0/main October 7, 2024 19:45 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants