Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created feature flag for CHAMPVA unique temp file names #19170

Conversation

stevelong00
Copy link
Contributor

@stevelong00 stevelong00 commented Oct 30, 2024

Summary

  • This work is behind a feature toggle (flipper): NO
  • Created a new feature flag for CHAMPVA unique temp file names
  • Not a bug
  • This feature flag is needed for some upcoming work
  • I work for IVC Forms / CHAMPVA
  • The success criteria with the new flipper is to be able to create temp files with unique file names that avoids collisions and fixes a bug in production

Related issue(s)

Testing done

  • New code is covered by unit tests
  • NA Describe what the old behavior was prior to the change
  • NA Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing

Screenshots

None

What areas of the site does it impact?

This only creates a new flipper, nothing else

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

None

Copy link

Backend-review-group approval confirmed.

@stevelong00 stevelong00 merged commit 58aef6c into master Oct 31, 2024
24 of 25 checks passed
@stevelong00 stevelong00 deleted the CHAMPVA-96132-create-feature-toggle-for-unique-temp-file-names branch October 31, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants