reverse flipper: champva_unique_temp_file_names

[cloudmagic80]

Summary

This PR removes the feature toggle related to champva_unique_temp_file_names .

Related issue(s)

#19143
#19170

Testing done

Tested on 7959f2 and 1010d with attachments.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[cloudmagic80]

1 Warning
⚠️ This PR changes 491 LoC (not counting whitespace/newlines).
In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews.

File Summary
Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

This warning doesn't apply to this PR since this PR only reverse the fillper

[github-actions]

1 Warning

⚠️

This PR changes 491 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files config/features.yml (+0/-3) modules/ivc_champva/app/controllers/ivc_champva/v1/uploads_controller.rb (+10/-23) modules/ivc_champva/app/services/ivc_champva/attachments.rb (+12/-33) modules/ivc_champva/app/services/ivc_champva/pdf_filler.rb (+11/-21) modules/ivc_champva/spec/models/vha_10_7959c_spec.rb (+5/-21) modules/ivc_champva/spec/models/vha_10_7959f_1_spec.rb (+5/-21) modules/ivc_champva/spec/models/vha_10_7959f_2_spec.rb (+5/-21) modules/ivc_champva/spec/services/attachments_spec.rb (+32/-83) modules/ivc_champva/spec/services/pdf_filler_spec.rb (+75/-110) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger