83846 disability benefits migrate 0781 a uploads to lighthouse

[ajones446]

This PR is a follow-up to #19186, which is the base PR that will allow us to progressively transition uploading 0781 forms to the new Lighthouse Documents Benefits API. This PR only adds specs to test the multiple conditions of uploading the 0781 and 0781a forms. The submit0781 job processes both forms 0781 and 0781a, if present.

All new behavior is hidden behind a killswitch flipper, disability_compensation_use_api_provider_for_0781_uploads, which will only use the API provider if turned on.

If the killswitch is enabled, the API Provider Factory itself will decide if we use the Lighthouse or EVSS provider client for the uploads, based on the status of the disability_compensation_upload_0781_to_lighthouse flipper.

Summary

• *This work is behind a feature toggle (flipper): YES (described above)
• (Summarize the changes that have been made to the platform)
• (If bug, how to reproduce)
• (What is the solution, why is this the solution?)
• (Which team do you work for, does your team own the maintenance of this component?)
  Disability Benefits team 2, aka Carbs; yes we do own the maintenance of these components
• (If introducing a flipper, what is the success criteria being targeted?)
  A certain amount of submissions will fail on upload to Lighthouse just as they do to EVSS now - it's the same underlying system; however we will be on the look out for new errors that expose bugs on our side or in Lighthouse's benefits documents API.

Related issue(s)

• Issue: [LH Doc Upload] 0781/a (1) implementation va.gov-team#83846
• Previous PR: 83846 disability benefits migrate 0781 uploads to lighthouse #19186

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
• If this work is behind a flipper:
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?
    This feature will be tested extensively on staging before release. It will be rolled out incrementally based on a percentage of production users, starting at 1%. All 0781 upload attempts will be logged and monitored.

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation) N/A
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable) Not yet, but we have a ticket to do this issue #95698
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

This is a lot of lines, but it is all within one spec file with considerable test setup and descriptions.

[github-actions]

1 Warning

⚠️

This PR changes 320 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files spec/sidekiq/evss/disability_compensation_form/submit_form0781_spec.rb (+299/-21) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[github-actions]

Backend-review-group approval confirmed.