Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0781 specs to log submission_id and submitted_claim_id #19251

Conversation

ajones446
Copy link
Contributor

@ajones446 ajones446 commented Nov 4, 2024

The 0781 job uses shared API provider logging values. This BDD PR #19217 updated logging to include submission_id as well as submitted_claim_id. This PR updates the specs to match.

Summary

  • *This work is behind a feature toggle (flipper): YES

  • (Summarize the changes that have been made to the platform)

  • (If bug, how to reproduce)

  • (What is the solution, why is this the solution?)

  • (Which team do you work for, does your team own the maintenance of this component?)
    Disability Benefits team 2, aka Carbs; yes we do own the maintenance of these components

  • (If introducing a flipper, what is the success criteria being targeted?)
    A certain amount of submissions will fail on upload to Lighthouse just as they do to EVSS now - it's the same underlying system; however we will be on the look out for new errors that expose bugs on our side or in Lighthouse's benefits documents API.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@ajones446 ajones446 marked this pull request as ready for review November 4, 2024 23:51
@ajones446 ajones446 requested review from a team as code owners November 4, 2024 23:51
Copy link

github-actions bot commented Nov 5, 2024

Backend-review-group approval confirmed.

@rmtolmach rmtolmach merged commit f55d3fd into master Nov 5, 2024
36 checks passed
@rmtolmach rmtolmach deleted the disability-benefits-fix-0781-api-provider-submission-logging branch November 5, 2024 12:55
@rmtolmach
Copy link
Contributor

@ajones446 I merged this because these tests were failing in master and blocking dev and staging deploys.

@ajones446
Copy link
Contributor Author

@rmtolmach Thank you, Rebecca! Sorry I missed that logging change that went in yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants