-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-41802-empty-unit-test #19305
Closed
Closed
API-41802-empty-unit-test #19305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n empty string if it is blank or empty. Adds test for nil and blank unitName.
github-actions
bot
added
omit-backend-approval
test-passing
ready-for-backend-review
and removed
omit-backend-approval
labels
Nov 6, 2024
va-vfs-bot
temporarily deployed
to
API-41802-empty-unit-test/main/main
November 6, 2024 21:49
Inactive
tycol7
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, minor suggestions.
modules/claims_api/app/controllers/concerns/claims_api/disability_compensation_validations.rb
Outdated
Show resolved
Hide resolved
github-actions
bot
added
require-backend-approval
and removed
ready-for-backend-review
omit-backend-approval
test-passing
labels
Nov 7, 2024
github-actions
bot
added
omit-backend-approval
require-backend-approval
test-passing
ready-for-backend-review
and removed
require-backend-approval
labels
Nov 7, 2024
va-vfs-bot
temporarily deployed
to
API-41802-empty-unit-test/main/main
November 8, 2024 21:43
Inactive
github-actions
bot
added
omit-backend-approval
and removed
omit-backend-approval
labels
Nov 12, 2024
va-vfs-bot
temporarily deployed
to
API-41802-empty-unit-test/main/main
November 12, 2024 15:10
Inactive
github-actions
bot
added
omit-backend-approval
and removed
omit-backend-approval
labels
Nov 13, 2024
github-actions
bot
added
omit-backend-approval
and removed
omit-backend-approval
labels
Nov 13, 2024
github-actions
bot
added
omit-backend-approval
test-failure
and removed
omit-backend-approval
labels
Nov 13, 2024
va-vfs-bot
temporarily deployed
to
API-41802-empty-unit-test/main/main
November 13, 2024 22:24
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
Screenshots
reservesNationalGuardService not provided example:What areas of the site does it impact?
Acceptance criteria