Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-41802-empty-unit-test #19305

Closed
wants to merge 14 commits into from
Closed

API-41802-empty-unit-test #19305

wants to merge 14 commits into from

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Nov 6, 2024

Summary

  • Adds transform method to v1 526 validations to change unitName to be an empty string if it is blank or empty.
  • Adds test for nil and blank unitName.

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Postman: v1 526. try sending a blank unitName & a nil unitName

Screenshots

Screenshot 2024-11-06 at 2 03 28 PM Screenshot 2024-11-06 at 2 12 58 PM Screenshot 2024-11-06 at 2 12 32 PM reservesNationalGuardService not provided example: Screenshot 2024-11-06 at 2 15 30 PM

What areas of the site does it impact?

modified:   modules/claims_api/app/controllers/concerns/claims_api/disability_compensation_validations.rb
modified:   modules/claims_api/spec/requests/v1/forms/526_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

…n empty string if it is blank or empty. Adds test for nil and blank unitName.
Copy link
Contributor

@tycol7 tycol7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, minor suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants