API-41802-empty-unit-test

modules/claims_api/app/controllers/concerns/claims_api/disability_compensation_validations.rb

@@ -25,6 +25,8 @@ def validate_form_526_submission_values!
       validate_service_after_13th_birthday!
       # ensure 'militaryRetiredPay.receiving' and 'militaryRetiredPay.willReceiveInFuture' are not same non-null values
       validate_form_526_service_pay!
+      # ensure an error is avoided if the unit name is not provided
+      transform_form_526_unit_name!
       # ensure 'title10ActivationDate' if provided, is after the earliest servicePeriod.activeDutyBeginDate and on or before the current date # rubocop:disable Layout/LineLength
       validate_form_526_title10_activation_date!
       # ensure 'title10Activation.anticipatedSeparationDate' is in the future
@@ -140,6 +142,15 @@ def validate_form_526_title10_anticipated_separation_date!
       )
     end
 
+    def transform_form_526_unit_name!
+      reserves = form_attributes&.dig('serviceInformation', 'reservesNationalGuardService')
+      return if reserves.nil?
+
+      unit_name = reserves['unitName']
+      unit_name = unit_name.presence || ' '
+      reserves['unit_name'] = unit_name
+    end
+
     def validate_form_526_submission_claim_date!
       return if form_attributes['claimDate'].blank?
       return if DateTime.parse(form_attributes['claimDate']) <= Time.zone.now

modules/claims_api/spec/requests/v1/forms/526_spec.rb

@@ -872,6 +872,60 @@
               end
             end
           end
+
+          context "when 'unitName' is empty" do
+            let(:unit_name) { '' }
+
+            it 'returns a successful response' do
+              mock_acg(scopes) do |auth_header|
+                VCR.use_cassette('claims_api/bgs/claims/claims') do
+                  VCR.use_cassette('claims_api/brd/countries') do
+                    par = json_data
+                    par['data']['attributes']['serviceInformation']['reservesNationalGuardService']['unitName'] =
+                      unit_name
+
+                    post path, params: par.to_json, headers: headers.merge(auth_header)
+                    expect(response).to have_http_status(:ok)
+                  end
+                end
+              end
+            end
+          end
+
+          context "when 'unitName' is nil" do
+            let(:unit_name) { nil }
+
+            it 'returns a successful response' do
+              mock_acg(scopes) do |auth_header|
+                VCR.use_cassette('claims_api/bgs/claims/claims') do
+                  VCR.use_cassette('claims_api/brd/countries') do
+                    par = json_data
+                    par['data']['attributes']['serviceInformation']['reservesNationalGuardService']['unitName'] =
+                      unit_name
+
+                    post path, params: par.to_json, headers: headers.merge(auth_header)
+                    expect(response).to have_http_status(:unprocessable_entity)
+                  end
+                end
+              end
+            end
+          end
+
+          context "when 'unitName' is not present" do
+            it 'returns a successful response' do
+              mock_acg(scopes) do |auth_header|
+                VCR.use_cassette('claims_api/bgs/claims/claims') do
+                  VCR.use_cassette('claims_api/brd/countries') do
+                    par = json_data
+                    par['data']['attributes']['serviceInformation']['reservesNationalGuardService'].delete('unitName')
+
+                    post path, params: par.to_json, headers: headers.merge(auth_header)
+                    expect(response).to have_http_status(:unprocessable_entity)
+                  end
+                end
+              end
+            end
+          end
         end
       end