[VI-740] SSOe: add MHV account creation after login

[rileyanderson]

Summary

• Skip ssoe after_login MHV account creation for specific clients
• Add skip_mhv_creation_api parameter to ToU redirect for specific clients that frontend will pass back when accepting ToU

Related issue(s)

• https://jira.devops.va.gov/browse/VI-740
• ToU - pass along skip_mhv_account_creation parameter on accept vets-website#33008

Testing done

checkout vi-740 on vets website

• Test logging in with SSOe
  • Change SKIP_MHV_ACCOUNT_CREATION_CLIENTS to [vaweb]
  • Sign In
  • It should not have enqueued MHV::AccountCreatorJob http://localhost3000/sidekiq/queues/default
• Test accepting ToU
  • with SKIP_MHV_ACCOUNT_CREATION_CLIENTS set to [vaweb]
    • it should not enqueue a job

What areas of the site does it impact?

ToU, MHV Account Creation,

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

[emilykim13]

I checked out vi-740 for both vets-api and vets-website. I made the changes you stated in the testing instructions. I checked sidekiq jobs queue and jobs did not enqueue upon sign in or upon accepting ToU. Lgtm

[rmtolmach]

@ me if the check-approval-requirements check is still pending after it's been approved by identity.

[github-actions]

1 Warning

⚠️

This PR changes 231 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files app/controllers/v0/terms_of_use_agreements_controller.rb (+11/-2) app/controllers/v1/sessions_controller.rb (+2/-1) app/services/login/after_login_actions.rb (+8/-2) lib/saml/post_url_service.rb (+9/-4) lib/saml/url_service.rb (+1/-0) spec/controllers/v0/terms_of_use_agreements_controller_spec.rb (+37/-2) spec/controllers/v1/sessions_controller_spec.rb (+24/-8) spec/lib/saml/post_url_service_spec.rb (+28/-42) spec/services/login/after_login_actions_spec.rb (+36/-14) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[bosawt]

@rmtolmach Good to go now

[github-actions]

Backend-review-group approval confirmed.