Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToU - pass along skip_mhv_account_creation parameter on accept #33008

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

rileyanderson
Copy link
Contributor

Summary

  • Update ToU to pass along skip_mhv_account_creation parameter on accept

Related issue(s)

Testing

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

Terms Of Use

Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

Copy link
Contributor

@harshil1793 harshil1793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try rerunning the failed test, specifically "Continuous Integration / Testing Reports - Cypress E2E Tests (push)"?

@asg5704
Copy link
Contributor

asg5704 commented Nov 14, 2024

Can we try rerunning the failed test, specifically "Continuous Integration / Testing Reports - Cypress E2E Tests (push)"?

Looks like its failing because its trying to parse JSON of artifacts that aren't downloaded (aka there aren't any changes)

@asg5704 asg5704 requested a review from harshil1793 November 15, 2024 18:57
@asg5704 asg5704 merged commit da601ba into main Nov 15, 2024
64 of 67 checks passed
@asg5704 asg5704 deleted the vi-740 branch November 15, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants