Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. Sentry tag cleanup #3205

Merged
merged 4 commits into from
Sep 9, 2019
Merged

Misc. Sentry tag cleanup #3205

merged 4 commits into from
Sep 9, 2019

Conversation

kfrz
Copy link
Contributor

@kfrz kfrz commented Aug 12, 2019 •
edited
Loading

Description of change

This PR cleans up a couple of minor Sentry tagging discrepancies. Jobs are automatically tagged and we are normalizing on external_service.

Testing done

Test suite

Testing planned

Check Sentry tags in staging

Acceptance Criteria (Definition of Done)

Unique to this PR

  • EMIS is tagged with external_service not backend_service

Applies to all PRs

  • Appropriate logging
  • Swagger docs have been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

@kfrz kfrz requested review from a team as code owners August 12, 2019 19:53
jholton
jholton approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@jholton jholton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

omgitsbillryan
omgitsbillryan approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@omgitsbillryan omgitsbillryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

J/w - where do we automatically tag jobs?

@kfrz kfrz merged commit 8d0d274 into master Sep 9, 2019
@kfrz
Copy link
Contributor Author

kfrz commented Sep 9, 2019

@omgitsbillryan

config/initializers/sidekiq.rb#L16 includes lib/sidekiq/error_tag.rb which does the taggin'.

🎆

@kfrz kfrz deleted the kfrz/sentry-cleanup branch September 9, 2019 19:55
@annaswims annaswims added the VSP VSP Contract label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omgitsbillryan omgitsbillryan omgitsbillryan approved these changes

@jholton jholton jholton approved these changes

Assignees
No one assigned
Labels
VSP VSP Contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kfrz @jholton @omgitsbillryan @annaswims @va-vfs-bot