Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. Sentry tag cleanup #3205

Merged
merged 4 commits into from
Sep 9, 2019
Merged

Misc. Sentry tag cleanup #3205

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fcbfb3
Change backend_service: :emis to external service in models/form_profile
kfrz Aug 12, 2019
ddfd23f
Remove redundant job tags in hca_submission and FacilityLocationDownl…
kfrz Aug 12, 2019
07639a5
Merge branch 'master' into kfrz/sentry-cleanup
kfrz Sep 9, 2019
7298ba1
Merge branch 'master' into kfrz/sentry-cleanup
kfrz Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/form_profile.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def initialize_military_information(user)
rescue => e
if Rails.env.production?
# fail silently if emis is down
log_exception_to_sentry(e, {}, backend_service: :emis)
log_exception_to_sentry(e, {}, external_service: :emis)
else
raise e
end
Expand Down
1 change: 0 additions & 1 deletion app/workers/facilities/facility_location_download_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ class FacilityLocationDownloadJob

def perform(type)
@type = type
Raven.tags_context(job: "FacilityLocationDownloadJob:#{type}")
ActiveRecord::Base.transaction do
process_changes
process_deletes
Expand Down
1 change: 0 additions & 1 deletion app/workers/hca/submission_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ class SubmissionJob
end

def perform(user_identifier, form, health_care_application_id, google_analytics_client_id)
Raven.tags_context(job: 'hca_submission')
health_care_application = HealthCareApplication.find(health_care_application_id)

begin
Expand Down
2 changes: 1 addition & 1 deletion spec/models/form_profile_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ def expect_prefilled(form_id)
expect(Rails.env).to receive(:production?).and_return(true)
expect(user.military_information).to receive(:hca_last_service_branch).and_return('air force').and_raise(error)
form_profile = described_class.for('1010ez')
expect(form_profile).to receive(:log_exception_to_sentry).with(error, {}, backend_service: :emis)
expect(form_profile).to receive(:log_exception_to_sentry).with(error, {}, external_service: :emis)
form_profile.prefill(user)
end
end
Expand Down