-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump axe-core and @axe-core/react #33113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything work locally for me. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not able to reproduce that error that I was getting previously with these changes running locally so this seems to fix it! Thanks Robert for jumping on this!
990475b
to
83406ab
Compare
83406ab
to
87683ce
Compare
Seems there is a legitimate new axe violation according to the new version of axe-core, where previously a test passed but now is failing. looking into this. |
d5e9fdb
87683ce
to
d5e9fdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
axe-core
and@axe-core/react
due to a regression inaxe-core
Related issue(s)
department-of-veterans-affairs/va.gov-team-forms#1872
Testing done
Browser testing
Screenshots
Fixes the following issue while developing on the front end:

What areas of the site does it impact?
Development
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?