Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump axe-core and @axe-core/react #33113

Merged
merged 2 commits into from
Nov 21, 2024
Merged

bump axe-core and @axe-core/react #33113

merged 2 commits into from
Nov 21, 2024

Conversation

rhasselle-oddball
Copy link
Contributor

Summary

  • bump axe-core and @axe-core/react due to a regression in axe-core
  • This error no longer shows up in new version.

Related issue(s)

  • Link to ticket created in va.gov-team repo
    department-of-veterans-affairs/va.gov-team-forms#1872

Testing done

Browser testing

Screenshots

Fixes the following issue while developing on the front end:
image

What areas of the site does it impact?

Development

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

harshil1793
harshil1793 previously approved these changes Nov 19, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/1872-bump-axe-core/main November 19, 2024 21:41 Inactive
michaelclement
michaelclement previously approved these changes Nov 19, 2024
Copy link
Contributor

@michaelclement michaelclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything work locally for me. Thanks!

Copy link
Contributor

@williamphelps13 williamphelps13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not able to reproduce that error that I was getting previously with these changes running locally so this seems to fix it! Thanks Robert for jumping on this!

Mottie
Mottie previously approved these changes Nov 20, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/1872-bump-axe-core/main November 20, 2024 01:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/1872-bump-axe-core/main November 20, 2024 16:24 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/1872-bump-axe-core/main November 20, 2024 19:47 Inactive
@rhasselle-oddball
Copy link
Contributor Author

Seems there is a legitimate new axe violation according to the new version of axe-core, where previously a test passed but now is failing. looking into this.

@rhasselle-oddball
Copy link
Contributor Author

New axe rule:
List element has direct children that are not allowed [role=presentation]

image
image
image

@williamphelps13 williamphelps13 self-requested a review November 21, 2024 17:32
Copy link
Contributor

@williamphelps13 williamphelps13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Mottie Mottie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhasselle-oddball rhasselle-oddball merged commit dba58d9 into main Nov 21, 2024
82 of 84 checks passed
@rhasselle-oddball rhasselle-oddball deleted the 1872-bump-axe-core branch November 21, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants