Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump axe-core and @axe-core/react #33113

Merged
merged 2 commits into from
Nov 21, 2024
Merged

bump axe-core and @axe-core/react #33113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e324169
bump axe-core and @axe-core/react
rhasselle-oddball Nov 19, 2024
d5e9fdb
Remove presentation role from appeals list
rhasselle-oddball Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
},
"devDependencies": {
"@actions/core": "^1.9.1",
"@axe-core/react": "^4.10.0",
"@axe-core/react": "^4.10.1",
"@babel/core": "^7.26.0",
"@babel/eslint-parser": "^7.25.9",
"@babel/parser": "^7.26.2",
Expand Down Expand Up @@ -143,7 +143,7 @@
"@webpack-cli/serve": "^1.6.0",
"append-query": "^2.1.1",
"autoprefixer": "^10.3.5",
"axe-core": "^4.4.3",
"axe-core": "^4.10.2",
"babel-core": "^7.0.0-bridge.0",
"babel-loader": "^8.2.2",
"babel-plugin-dynamic-import-node": "^2.3.3",
Expand Down
2 changes: 1 addition & 1 deletion src/applications/claims-status/components/appeals-v2/PastEvent.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
hideSeparator === true ? null : <div className="separator" />;

return (
<li role="presentation" className={'process-step section-complete'}>
<li className="process-step section-complete">
<h3>{title}</h3>
<div className="appeal-event-date">on {date}</div>
<p>{description}</p>
Expand All @@ -17,8 +17,8 @@

PastEvent.propTypes = {
title: PropTypes.string.isRequired,
date: PropTypes.string.isRequired,

Check warning on line 20 in src/applications/claims-status/components/appeals-v2/PastEvent.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/claims-status/components/appeals-v2/PastEvent.jsx:20:3:Prop types declarations should be sorted alphabetically
description: PropTypes.string.isRequired,

Check warning on line 21 in src/applications/claims-status/components/appeals-v2/PastEvent.jsx

View workflow job for this annotation

GitHub Actions / Linting (Files Changed) 

src/applications/claims-status/components/appeals-v2/PastEvent.jsx:21:3:Prop types declarations should be sorted alphabetically
hideSeparator: PropTypes.bool,
};

Expand Down
2 changes: 2 additions & 0 deletions src/applications/claims-status/tests/e2e/07.appeal-status.cypress.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ describe('Appeals page test', () => {
cy.get('a.ddl-link').click();

cy.get('h1').should('contain', 'Your VA claim and appeal letters');
cy.injectAxeThenAxeCheck();
});

it('should show DDL link for post-decided appeal ', () => {
Expand All @@ -96,5 +97,6 @@ describe('Appeals page test', () => {
cy.get('a.ddl-link').click();

cy.get('h1').should('contain', 'Your VA claim and appeal letters');
cy.injectAxeThenAxeCheck();
});
});
23 changes: 9 additions & 14 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@
"@jridgewell/gen-mapping" "^0.3.0"
"@jridgewell/trace-mapping" "^0.3.9"

"@axe-core/react@^4.10.0":
version "4.10.0"
resolved "https://registry.yarnpkg.com/@axe-core/react/-/react-4.10.0.tgz#124cde86b9bbbf44fd0f2c787beed186b8b9a3d4"
integrity sha512-gpFj1+G0zabbd0ZDum1N5FPJtUOfPIfslXNH58WuR7opSK0WTwPJ49ZlYr/Wg2fA4VGI5lfkG5fAZSG9p8ecKw==
"@axe-core/react@^4.10.1":
version "4.10.1"
resolved "https://registry.yarnpkg.com/@axe-core/react/-/react-4.10.1.tgz#f9ab3012e14a399426b1f2599bfe5cae4957bc0d"
integrity sha512-GRGx/3Gbce9WQYXgY0iZzqOaHIRXBNGyV+zoUhJzBuDeoTL+XoeY3u/9PzdIVyH0pbNs1n1RChfsmWBy6hzKPg==
dependencies:
axe-core "~4.10.0"
axe-core "~4.10.2"
requestidlecallback "^0.3.0"

"@babel/code-frame@7.12.11":
Expand Down Expand Up @@ -5875,15 +5875,10 @@ axe-core@=4.7.0:
resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.7.0.tgz#34ba5a48a8b564f67e103f0aa5768d76e15bbbbf"
integrity sha512-M0JtH+hlOL5pLQwHOLNYZaXuhqmvS8oExsqB1SBYgA4Dk7u/xx+YdGHXaK5pyUfed5mYXdlYiphWq3G8cRi5JQ==

axe-core@^4.4.3:
version "4.4.3"
resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.4.3.tgz#11c74d23d5013c0fa5d183796729bc3482bd2f6f"
integrity sha512-32+ub6kkdhhWick/UjvEwRchgoetXqTK14INLqbGm5U2TzBkBNF3nQtLYm8ovxSkQWArjEQvftCKryjZaATu3w==

axe-core@~4.10.0:
version "4.10.1"
resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.10.1.tgz#7d2589b0183f05b0f23e55c2f4cdf97b5bdc66d9"
integrity sha512-qPC9o+kD8Tir0lzNGLeghbOrWMr3ZJpaRlCIb6Uobt/7N4FiEDvqUMnxzCHRHmg8vOg14kr5gVNyScRmbMaJ9g==
axe-core@^4.10.2, axe-core@~4.10.2:
version "4.10.2"
resolved "https://registry.yarnpkg.com/axe-core/-/axe-core-4.10.2.tgz#85228e3e1d8b8532a27659b332e39b7fa0e022df"
integrity sha512-RE3mdQ7P3FRSe7eqCWoeQ/Z9QXrtniSjp1wUjt5nRC3WIpz5rSCve6o3fsZ2aCpJtrZjSZgjwXAoTO5k4tEI0w==

axios@^0.21.1, axios@^1.1.3:
version "0.21.4"
Expand Down
Loading