Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pub] use 'increase-if-necessary' as the default strategy for pub dependencies #6786

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

devoncarew
Copy link

  • change the default versioning strategy for pub dependencies to increase-if-necessary
  • as a side-effect, no longer use the pubspec.yaml 'version' field to try and identify an app vs a package (they'll both get the same default strategy)

I believe this is generally in-line with what's discussed in #4979.

@devoncarew devoncarew requested a review from a team as a code owner March 4, 2023 06:14
@jeffwidman
Copy link
Member

jeffwidman commented Mar 6, 2023

I approved CI to see if any unit tests need updating for this.

Before merging, I want to take one more gander at #4979 and think carefully about the choices there... at first glance, the arguments presented there could just as easily apply to most other ecosystems... not saying it's a bad idea, just that I want to think on it overnight. I'll post in that issue if I have any concerns.

@devoncarew
Copy link
Author

devoncarew commented Mar 6, 2023

Before merging, I want to take one more gander at #4979 and think carefully about the choices there... at first glance, the arguments presented there could just as easily apply to most other ecosystems... not saying it's a bad idea, just that I want to think on it overnight. I'll post in that issue if I have any concerns.

No worries - I'm fine with taking some time to think through the changes (and I'll circle back to this PR to address the test failures).

@mafreud
Copy link

mafreud commented Dec 15, 2024

@devoncarew, Could you resume fixing the conflicts? I agree with that default versioning strategy for pub is increase-if-necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants