Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dependabot configs. #2128

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

godofredoc
Copy link
Contributor

This is to validate we can use app top level folders to config updates of inner pubspec files.

Bug: flutter/flutter#136983

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

This is to validate we can use app top level folders to config updates
of inner pubspec files.

Bug: flutter/flutter#136983
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to validate we can use app top level folders to config updates of inner pubspec files.

Even with that, consider also adding: versioning-strategy: increase-if-necessary

The pub adaptor for dependabot will otherwise default to widen, which isn't what we want here (we want ^3.0.0, instead of something like >=2.1.0 <4.0.0). See also dependabot/dependabot-core#6786 and dependabot/dependabot-core#4979.

@godofredoc
Copy link
Contributor Author

dependabot/dependabot-core#4979

Even with that, consider also adding: versioning-strategy: increase-if-necessary

The pub adaptor for dependabot will otherwise default to widen, which isn't what we want here (we want ^3.0.0, instead of something like >=2.1.0 <4.0.0). See also dependabot/dependabot-core#6786 and dependabot/dependabot-core#4979.

Done!

@godofredoc godofredoc merged commit 416c106 into flutter:main Oct 20, 2023
8 of 11 checks passed
@godofredoc godofredoc deleted the fix_dependabot branch October 20, 2023 23:27
@domesticmouse
Copy link
Contributor

This is to validate we can use app top level folders to config updates of inner pubspec files.

If we can update inner pubspec.yaml files, is there a reason not to use / as the target directory to update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants