Stop explicitly catching missing env-var error in composer
#7675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes explicitly catching errors about missing env vars.
This is likely a bit controversial, so here's my thinking:
ACF Pro
, but that is no longer relevant since they now support privatecomposer
auth natively: Support using custom PHP environment variables to pass API key to paid plugins #2001 (comment)composer
tooling, rather than a workaround. We aren't going to go out of our way to support non-standard tooling practices.composer
errors are hidden, but we should resolve that with a systemic solution rather than one-off-solutions for specific packages, which turns into a game of whack-a-mole: Expose composer error message when not resolvable #6290TODO
notes saying we should refactor/cleanup our error handling code. And we don't even know what's still relevant once we dropcomposer
1
as the error messages changed a bit. So any cleanup / simplification we can do of the error handling code makes our future refactoring easier.If we needed this generic error for other ecosystems, that'd make sense, but so far it's
composer
specific so until we need that, let's just remove it.