Stop explicitly catching missing env-var error in composer

bin/dry-run.rb

@@ -441,13 +441,6 @@ def handle_dependabot_error(error:, dependency:)
         "error-type": "private_source_certificate_failure",
         "error-detail": { source: error.source }
       }
-    when Dependabot::MissingEnvironmentVariable
-      {
-        "error-type": "missing_environment_variable",
-        "error-detail": {
-          "environment-variable": error.environment_variable
-        }
-      }
     when Dependabot::GoModulePathMismatch
       {
         "error-type": "go_module_path_mismatch",

common/lib/dependabot/errors.rb

@@ -149,15 +149,6 @@ def initialize(source)
     end
   end
 
-  class MissingEnvironmentVariable < DependabotError
-    attr_reader :environment_variable
-
-    def initialize(environment_variable)
-      @environment_variable = environment_variable
-      super("Missing environment variable #{@environment_variable}")
-    end
-  end
-
   # Useful for JS file updaters, where the registry API sometimes returns
   # different results to the actual update process
   class InconsistentRegistryResponse < DependabotError; end

composer/lib/dependabot/composer/file_updater/lockfile_updater.rb

@@ -182,20 +182,6 @@ def handle_composer_errors(error)
             raise Dependabot::GitDependenciesNotReachable, dependency_url
           end
 
-          # NOTE: This matches an error message from composer plugins used to install ACF PRO
-          # https://github.com/PhilippBaschke/acf-pro-installer/blob/772cec99c6ef8bc67ba6768419014cc60d141b27/src/ACFProInstaller/Exceptions/MissingKeyException.php#L14
-          # https://github.com/pivvenit/acf-pro-installer/blob/f2d4812839ee2c333709b0ad4c6c134e4c25fd6d/src/Exceptions/MissingKeyException.php#L25
-          if error.message.start_with?("Could not find a key for ACF PRO", "Could not find a license key for ACF PRO")
-            raise MissingEnvironmentVariable, "ACF_PRO_KEY"
-          end
-
-          # NOTE: This matches error output from a composer plugin (private-composer-installer):
-          # https://github.com/ffraenz/private-composer-installer/blob/8655e3da4e8f99203f13ccca33b9ab953ad30a31/src/Exception/MissingEnvException.php#L22
-          if error.message.match?(MISSING_ENV_VAR_REGEX)
-            env_var = error.message.match(MISSING_ENV_VAR_REGEX).named_captures.fetch("env_var")
-            raise MissingEnvironmentVariable, env_var
-          end
-
           if error.message.start_with?("Unknown downloader type: npm-sign") ||
              error.message.include?("file could not be downloaded") ||
              error.message.include?("configuration does not allow connect")

composer/spec/dependabot/composer/file_updater/lockfile_updater_spec.rb

@@ -268,55 +268,6 @@
       end
     end
 
-    context "that requires an environment variable (composer v1)" do
-      let(:project_name) { "v1/env_variable" }
-
-      context "that hasn't been provided" do
-        it "raises a MissingEnvironmentVariable error" do
-          expect { updated_lockfile_content }.to raise_error do |error|
-            expect(error).to be_a(Dependabot::MissingEnvironmentVariable)
-            expect(error.environment_variable).to eq("ACF_PRO_KEY")
-          end
-        end
-      end
-
-      context "that has been provided" do
-        let(:updater) do
-          described_class.new(
-            dependency_files: files,
-            dependencies: [dependency],
-            credentials: [{
-              "type" => "git_source",
-              "host" => "github.com",
-              "username" => "x-access-token",
-              "password" => "token"
-            }, {
-              "type" => "php_environment_variable",
-              "env-key" => "ACF_PRO_KEY",
-              "env-value" => "example_key"
-            }]
-          )
-        end
-
-        it "runs just fine (we get a 404 here because our key is wrong)" do
-          expect { updated_lockfile_content }.to raise_error do |error|
-            expect(error).to be_a(Dependabot::DependencyFileNotResolvable)
-            expect(error.message).to include("404")
-          end
-        end
-      end
-    end
-
-    context "that requires an environment variable (composer v2)" do
-      let(:project_name) { "env_variable" }
-
-      context "that hasn't been provided" do
-        it "does not attempt to download and has details of the updated item" do
-          expect(updated_lockfile_content).to include("\"version\":\"5.9.2\"")
-        end
-      end
-    end
-
     context "with a path source" do
       let(:project_name) { "path_source" }
 

updater/lib/dependabot/updater/error_handler.rb

@@ -147,13 +147,6 @@ def error_details_for(error, dependency: nil, dependency_group: nil) # rubocop:d
             "error-type": "private_source_certificate_failure",
             "error-detail": { source: error.source }
           }
-        when Dependabot::MissingEnvironmentVariable
-          {
-            "error-type": "missing_environment_variable",
-            "error-detail": {
-              "environment-variable": error.environment_variable
-            }
-          }
         when Dependabot::GoModulePathMismatch
           {
             "error-type": "go_module_path_mismatch",