Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pipenv from 2022.4.8 to 2023.7.23 in /python/helpers #7715

Closed
wants to merge 4 commits into from
Closed

Bump pipenv from 2022.4.8 to 2023.7.23 in /python/helpers #7715

wants to merge 4 commits into from

Commits on Aug 18, 2023

  1. Bump pipenv from 2022.4.8 to 2023.7.23 in /python/helpers 

    Bumps [pipenv](https://github.com/pypa/pipenv) from 2022.4.8 to 2023.7.23.
- [Release notes](https://github.com/pypa/pipenv/releases)
- [Changelog](https://github.com/pypa/pipenv/blob/main/CHANGELOG.rst)
- [Commits](pypa/pipenv@v2022.4.8...v2023.7.23)

---
updated-dependencies:
- dependency-name: pipenv
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
    @dependabot @jeffwidman
    dependabot[bot] authored and jeffwidman committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    db59711 View commit details
    Browse the repository at this point in the history

  2. error message changed for git dep unreachable 

    Old error format:
```
ERROR:pip.subprocessor:Command errored out with exit status 128:\n command: git clone -q https://github.com/user/django.git
```

New format:
```
ERROR:pip.subprocessor:[present-rich] git clone --filter=blob:none https://github.com/user/django.git /tmp/reqlib-src4k0l3qz3/django_56e3fa519acb44ee941b689a515b62fe exited with 128
```

Updated the regex accordingly.
    @jeffwidman
    jeffwidman committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    8eb9381 View commit details
    Browse the repository at this point in the history

  3. Match new Git reference not found error message format 

    The format of this error message changed.

Old message:
```
ERROR:pip.subprocessor:Command errored out with exit status 1:
 command: git checkout -q v15.1.2
      cwd: /tmp/pipenv-4y8m31vy-src/pythonfinder
Complete output (1 lines):
error: pathspec 'v15.1.2' did not match any file(s) known to git
<full traceback>
```

New message:
```
ERROR:pip.subprocessor:[present-rich] git checkout -q v15.1.2 exited with 1
<full traceback>
```

So updated the regex to match the new format.

Unfortunately the dependency name is nowhere to be found in the error
message or full traceback, so we can no longer provide the user with
that helpful information.

I'm planning to reach out to the `pipenv` maintainers to see if they'd
be open to exposing that information again in this error message.
    @jeffwidman
    jeffwidman committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    ce5600a View commit details
    Browse the repository at this point in the history

  4. pipenv renamed internal patch.notpip -> patch.pip 

    Upstream `pipenv` renamed their internal patched version of `pip` folder
to be called `patch.pip`:
* pypa/pipenv#5199

So this updates our code as well.
    @jeffwidman
    jeffwidman committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    52d620f View commit details
    Browse the repository at this point in the history