-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pipenv from 2022.4.8 to 2023.7.23 in /python/helpers #7715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked until we drop Python 3.6 support, although personally I'd rather stack this behind the 3.7
drop as well so we start from a clean slate:
Fixing the failing tests may require some combination of: |
3eca4ba
to
9dbdbc5
Compare
9dbdbc5
to
8b1c64e
Compare
34bca45
to
de961de
Compare
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
de961de
to
a86590d
Compare
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
a86590d
to
2c168ae
Compare
In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in #7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
7267496
to
6db4da1
Compare
4f2af03
to
3f37636
Compare
8564a3c
to
250fa2b
Compare
Bumps [pipenv](https://github.com/pypa/pipenv) from 2022.4.8 to 2023.7.23. - [Release notes](https://github.com/pypa/pipenv/releases) - [Changelog](https://github.com/pypa/pipenv/blob/main/CHANGELOG.rst) - [Commits](pypa/pipenv@v2022.4.8...v2023.7.23) --- updated-dependencies: - dependency-name: pipenv dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Old error format: ``` ERROR:pip.subprocessor:Command errored out with exit status 128:\n command: git clone -q https://github.com/user/django.git ``` New format: ``` ERROR:pip.subprocessor:[present-rich] git clone --filter=blob:none https://github.com/user/django.git /tmp/reqlib-src4k0l3qz3/django_56e3fa519acb44ee941b689a515b62fe exited with 128 ``` Updated the regex accordingly.
The format of this error message changed. Old message: ``` ERROR:pip.subprocessor:Command errored out with exit status 1: command: git checkout -q v15.1.2 cwd: /tmp/pipenv-4y8m31vy-src/pythonfinder Complete output (1 lines): error: pathspec 'v15.1.2' did not match any file(s) known to git <full traceback> ``` New message: ``` ERROR:pip.subprocessor:[present-rich] git checkout -q v15.1.2 exited with 1 <full traceback> ``` So updated the regex to match the new format. Unfortunately the dependency name is nowhere to be found in the error message or full traceback, so we can no longer provide the user with that helpful information. I'm planning to reach out to the `pipenv` maintainers to see if they'd be open to exposing that information again in this error message.
Upstream `pipenv` renamed their internal patched version of `pip` folder to be called `patch.pip`: * pypa/pipenv#5199 So this updates our code as well.
250fa2b
to
52d620f
Compare
A newer version of pipenv exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
…ot#7764) In the versions between what we are currently on in `dependaobt-core` and the latest versions of `pipenv`, they deprecated and then completely removed the `pipenv lock [-d]` command in favor of `pipenv requirements [--dev]` command. Since our current version of `pipenv` supports the `pipenv requirements` command, let's proactively switch to it now. That will make the future upgrade in dependabot#7715 easier. More context: * pypa/pipenv#5069 * pypa/pipenv#5091 * pypa/pipenv#5198 * pypa/pipenv#5200
Bumps pipenv from 2022.4.8 to 2023.7.23.
Release notes
Sourced from pipenv's releases.
... (truncated)
Changelog
Sourced from pipenv's changelog.
... (truncated)
Commits
836e756
Release v2023.7.23839554d
add news fragment662a521
Vendor in pythonfinder==2.0.576d40f5
add commentsa72e961
add news fragmentb3fefa5
Restore prior resolver default behavior but maintain direct code path for tes...c37f031
add news fragment.492ed44
re-run vendoring after removing patch5618166
Vendor in pip 23.2301d204
Update safety patchDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)