Array of tasks in after/before are reversed

[erropix]

I am not sure what the reason the tasks list is reversed on before/after hooks:

deployer/src/Importer/Importer.php

Lines 239 to 250 in bc708be

	protected static function after(array $after)
	{
	foreach ($after as $key => $value) {
	if (is_array($value)) {
	foreach (array_reverse($value) as $v) {
	after($key, $v);
	}
	} else {
	after($key, $value);
	}
	}
	}

This makes no sense as we have to write the tasks in the opposite order of their execution.

[antonmedv]

Don’t remember) we can remove it. I guess.

[erropix]

I just found out it was added in v7 1d137ad but the commit description doesn't mention anything about the tasks bein reversed and this behavior is not documented either

[erropix]

@antonmedv any update on this?

[hwmaier]

I found this behaviour unexpected and a bit confusing. At least it should be documented, but I believe even better the order should be changed to what most people would expect: top of the list first, bottom last.

[Schrank]

At you all: Feel free to provide a PR yourself, especially for so easy tasks like this.

Now 🤞 the CI is green :-)

[erropix]

@antonmedv I guess the YAML array order for me is different than what's shown in #3431

Any idea what may cause this strange order difference?

[SimJoSt]

I can confirm, that the order of tasks via the after hook is still an issue for me as well. before executes the tasks in the order they appear in the yaml file.
As a breaking change, it would probably need to go into a major release.

@antonmedv can you reopen this issue, so we can track this?