Make Deployer work with PHP 8.2 #3422
Conversation
|
Isn't the composer.lock ignored when a library is required by a project? I always thought so. And I don't think I misread the documentation (https://getcomposer.org/doc/02-libraries.md#lock-file). So your change should in theory have no effect. |
|
And the php 8.2 checks are missing deployer/.github/workflows/test.yml Line 14 in 1f5cfb2 |
The thing here, if I'm not wrong, is that this change would have effect in the next release because of this job: https://github.com/deployphp/deployer/blob/1f5cfb25c247506b8d2a12484c87f9b8b3fe3f9b/.github/workflows/release.yml When a release is created, it executes If you see https://packagist.org/packages/deployer/deployer#v7.0.2 there are no requirements there. |
|
@antonmedv Can you please release a new version with that PR merged? |
|
Will try to do it today. |
* origin/master: (33 commits) Update default cachetool version to 9.0.0 (PHP 8.1 compatible) (deployphp#3462) Update UPGRADE.md (deployphp#3458) update writable deploy recipe to use release_or_current_path (deployphp#3449) Fix PostgreSQL provisioning Fix PostgresDB user creation Show failed tasks for CI-environments (deployphp#3446) Fix NodeJS 12 warning: update EndBug/add-and-commit action (deployphp#3442) Replace unmaintained satackey/push-prebuilt-action by a maintained fork (deployphp#3437) Fix Node.js 12 actions are deprecated (deployphp#3435) Fix set-output command is deprecated and will be disabled soon (deployphp#3436) Add "new version" banners on release Revert "Fixes deployphp#3365 (deployphp#3400)" Make Deployer work with PHP 8.2 (deployphp#3422) Update symfony/console to ^5.4.9 Update symfony/console to ^5.4.9 Test on php 8.2 as well Revert "Composer update" Composer update [automatic] Update docs with bin/docgen Feature/magento2 artifact deployment (deployphp#3317) ...
Replaces #3401
Using @Konafets' work and updating the composer.lock file
Closes #3399 and #3401