This repository has been archived by the owner on Dec 20, 2017. It is now read-only.
Sync updates from NCIA #762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
search component
Advisor reports table is called dynamically from the insights menu. Show calander parameter is added to toggle the calander filter, since it is not needed in the Advisor Reports table.
long methods
This searches for reports authored by people serving in that position at the report's creation date.
This searches for reports attended by people (either principals or advisors) serving in that position at the engagement date.
true on get methods
Fix advisor reports show on insights page
Report the number of engagement reports submitted within a given time frame
#195: Filter reports by author or attendee position
Also, moved badges to the very top
Also call loadApprovers() to make sure the collection is loaded.
#262: Validate approval steps to have a required name and approver
Otherwise the user will see the default "Internal Server Error" which is confusing.
#262: Explicitly return BAD_REQUEST for validation errors
Added @dds.mil to the domain whitelist, so the test will pass Custom email validation should only be triggered if it is set by the api call, because API test calls are made without an email.
Release 2.0.1
Use the correct variable for the support address in the dictionary
|
Beware it contains stuff specific to our repo - mostly in .travis.yml |
This makes sure that the type of an organization can only be changed by an admin. It also makes sure that for principal organizations only the admin can edit the parent organization and long name.
GH-194-fix - add server side custom email validation check
This is needed in order to be able to refer to the table in the Selenium tests.
#20: Show report approval status for all reports not in draft or future state
This adds tests related to the permissions of a super user when editing a principal organization. A super user is only allowed to edit the shortName of a principal organization.
This adds tests to check the permissions of admin users on editing principal organizations: they are allowed to edit all fields.
#36: Update the ability of super users to modify principal organizations
ANET 2.0.2 release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are finally getting into more regular releases, it may be a good time for a PR