fix(selenium): ensure switchTo() does not fail using SafariDriver #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidious
commented
Nov 18, 2023
Comment on lines
+46
to
+47
| - dependency-name: "org.mockito:mockito-core" | ||
| versions: [ ">=5.0.0" ] |
Zidious
commented
Nov 18, 2023
| @@ -1,215 +1,224 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | |||
There was a problem hiding this comment.
Apologies - this must have been formatting after adding Mockito
Zidious
commented
Nov 18, 2023
Comment on lines
-124
to
-128
| JavascriptExecutor driver = (JavascriptExecutor) webDriver; | ||
| driver.executeScript("window.open('about:blank', '_blank')"); | ||
| ArrayList<String> handles = new ArrayList<String>(webDriver.getWindowHandles()); | ||
| String abHandle = handles.get(handles.size() - 1); | ||
| webDriver.switchTo().window(abHandle); |
There was a problem hiding this comment.
I tried to look at the git history to see why we did it this way vs newWindow(..) but couldn't find anything
…-html into fix-safari-switch-two-issue
1 task
|
Unfortunately, Putting this into draft until we can introduce a breaking change into our API's |
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this was a strange one. The way we were opening
about:blankand handles was a bit strange. Using the Safari driver going to any website would would causeNoSuchWindowExceptionerror. This would consistently throw when testing locally. After some digging, it appears when we calleddriver.executeScript("window.open('about:blank', '_blank')");and attempt toswitchTo()to the new window it would cause open theabout:blankpage and cause the current handle (the page being analyzed) to also navigate to theabout:blankpage, it appears the window handle would reference itself and not the newly opened page.To avoid doing
executeScriptand checking window handles, we can simply lean on Selenium for switching to a new window that is a tab and safely navigate toabout:blank.I also noticed
WebDriverExtensionsTest.javawas missing a tests, so I added some there.Closes: #391