-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebdriverJS with the Safari driver causes noSuchWindowException #936
Comments
This is the workaround fix that supports Selenium 3 and 4. We would likely switch to #1027 should we drop Selenium 3 support. Rather than always using the last handle after opening a new window, we filter for the unique new handle and use it. This is analogous to the [axe-core-maven-html approach](https://github.com/dequelabs/axe-core-maven-html/blob/ad58b26a8d0e2f1afed33b2c5cbca22b54644b99/selenium/src/main/java/com/deque/html/axecore/extensions/WebDriverExtensions.java#L126). Closes: #936 --------- Co-authored-by: Zidious <Zidious@users.noreply.github.com> Co-authored-by: michael-siek <me@michaelsiek.com>
Verified this with the latest RC-build (4.9.1-4cb64b0.0 )
for this Code used
and enabled the 'Allow Remote Automation' option in Safari's Develop menu also to control Safari via WebDriver Environment:
@Zidious / @michael-siek can you please take a look into this Note: Tried with |
I'm not able to reproduce this, but I wonder if it's because of the requirement to enable safaridriver. |
Getting the results when executing on Safari Browser,
Result file attaching with Environment:
|
Product
webdriverjs
Product Version
4.8.0
Latest Version
Issue Description
Expectation
Print axe results
Actual
Throws an error
How to Reproduce
Additional context
Run into the same issue in Ruby and Java.
We should look to to removing:
axe-core-npm/packages/webdriverjs/src/index.ts
Lines 276 to 285 in 5fcb30f
In favour of something like:
Selenium doesn't appear to document the above in their docs, but it's available within their source code
The text was updated successfully, but these errors were encountered: