Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): replace axe-webdriverjs in favor of @axe-core/webdriverjs #51

Merged
merged 7 commits into from
Jul 14, 2020
Merged

feat(cli): replace axe-webdriverjs in favor of @axe-core/webdriverjs #51

merged 7 commits into from
Jul 14, 2020

Conversation

michael-siek
Copy link
Member

@michael-siek michael-siek commented Jul 14, 2020 •
edited by stephenmathieson
Loading

See: #50

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Code is reviewed for security

@michael-siek michael-siek requested a review from a team July 14, 2020 01:26
@stephenmathieson
Copy link
Member

I don't think this is a breaking change, since the CLI (should) function exactly the same.

@michael-siek
Copy link
Member Author

Have to fix lerna stuff

stephenmathieson
stephenmathieson reviewed Jul 14, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@michael-siek michael-siek merged commit 734a795 into develop Jul 14, 2020
@michael-siek michael-siek deleted the cli-use-webdriver branch July 14, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-siek @stephenmathieson