Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci,webdriverjs): update selenium-webdriver to latest #673

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

straker
Copy link
Contributor

@straker straker commented Feb 23, 2023

Updated selenium webdriver to latest so we're not pinned anymore to an older version.

Closes #580

@straker straker requested a review from a team as a code owner February 23, 2023 00:12
Zidious
Zidious previously approved these changes Feb 23, 2023
Copy link
Contributor

@Zidious Zidious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I remember this was changed in axe-core too - LGTM

Could this be considered a fix? #580

@michael-siek
Copy link
Member

LGTM but we should probably do it in the webdriverjs package as well to mitigate typescript issues

michael-siek
michael-siek previously approved these changes Feb 24, 2023
@straker straker changed the title chore(ci): update selenium-webdriver to latest chore(ci,webdriverjs): update selenium-webdriver to latest Feb 24, 2023
@straker straker merged commit b142be9 into develop Feb 28, 2023
@straker straker deleted the cli-webdriver branch February 28, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate CLI / WebdriverJS chrome.setDefaultService
4 participants