chore: release v4.6.1 #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
chore: merge master into develop
* fix: work with extremely large partial results * fix tests * try again
* chore(ci): update selenium-webdriver to latest * fix tests * udpate webdriverjs
The webdriverio CI job was failing with the error message:
session not created: This version of ChromeDriver only supports Chrome version 109
Current browser version is 111.0.5563.64 with binary path /usr/bin/google-chrome
Despite the job running the following steps:
- browser-tools/install-chrome
- browser-tools/install-chromedriver
- run: npm run coverage --prefix=packages/webdriverio
And browser-tools/install-chromedriver automatically installing the
right version of chromedriver based on the previously installed chrome
version.[1]
This was because browser-tools/install-chromedriver installed the
chromedriver under /usr/local/bin/chromedriver while
packages/webdriverio/src/test.ts was using the chromedriver from the
chromedriver NPM package (which is currently set to ^109.0.0 in
package.json).
This commit changes the webdriverio test code to instead use the
system-wide installed chromedriver (that has been installed via
browser-tools/install-chromedriver) in a CI environment.
[1]: https://circleci.com/developer/orbs/orb/circleci/browser-tools#commands-install-chromedriver
* refactor(webdriverjs): make code more DRY * refactor: make tests respect CHROMEDRIVER_PATH
* chore(puppeteer): allow using v19 * use lateset chromedriver * fix cache path for v19 * try again * fix(ci): add puppeteer executable path * remove config file --------- Co-authored-by: Colin Rotherham <work@colinr.com>
Co-authored-by: michael-siek <michael-siek@users.noreply.github.com>
michael-siek
approved these changes
Mar 28, 2023
|
reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action
4.6.1 (2023-03-28)
Bug Fixes
Features