-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add roles added in ARIA 1.2 #2107
Labels
good first issue
For first-time contributors
hacktoberfest
Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/
Comments
straker
added
the
help wanted
We welcome PRs or discussions for issues marked as help wanted
label
Jul 29, 2020
See the ariaRole standards docs for how to do this |
straker
added
good first issue
For first-time contributors
and removed
help wanted
We welcome PRs or discussions for issues marked as help wanted
labels
Aug 20, 2020
straker
added
the
hacktoberfest
Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/
label
Oct 1, 2020
Hey there! I'm trying to gain more experience with accessibility, and I'd love to work on this issue! |
All yours. Let me know if you need anything. |
PS. I find running the following script while in the WCAG 1.2 spec page helps seeing which ARIA attributes to add to the const globalAttrs = Array.from(
document.querySelectorAll('#global_states li')
).map(li => li.textContent.replace(/\s*\(.*\)/, ''));
const globalRoleAttrs = Array.from(
document.querySelectorAll('.role-inherited li, .role-properties li')
).filter(li => globalAttrs.includes(li.textContent.replace(/\s*\(.*\)/, '')))
globalRoleAttrs.forEach(li => li.style.display = 'none'); |
timmybytes
added a commit
to timmybytes-contributing/axe-core
that referenced
this issue
Oct 7, 2020
Adds new roles from WAI-ARIA 1.2 spec Closes issue dequelabs#2107
2 tasks
timmybytes
added a commit
to timmybytes-contributing/axe-core
that referenced
this issue
Oct 7, 2020
Adds new roles from WAI-ARIA 1.2 spec to test/commons/standards/get-aria-roles-by-type.js Closes issue dequelabs#2107
timmybytes
added a commit
to timmybytes-contributing/axe-core
that referenced
this issue
Oct 7, 2020
Adds the allowedAttrs: ['aria-valuetext'] to the meter role Closes issue dequelabs#2107
timmybytes
added a commit
to timmybytes-contributing/axe-core
that referenced
this issue
Oct 9, 2020
Adds treegrid to caption role's requiredContext array. Closes issue: dequelabs#2107
WilcoFiers
pushed a commit
that referenced
this issue
Oct 9, 2020
* fix(aria-roles): Add WAI-ARIA 1.2 roles Adds new roles from WAI-ARIA 1.2 spec Closes issue #2107 * fix(aria-roles): Add WAI-ARIA 1.2 roles to testing Adds new roles from WAI-ARIA 1.2 spec to test/commons/standards/get-aria-roles-by-type.js Closes issue #2107 * fix(aria-roles): Add allowedAttrs for meter role Adds the allowedAttrs: ['aria-valuetext'] to the meter role Closes issue #2107 * fix(aria-roles): Add 'treegrid' to caption Adds treegrid to caption role's requiredContext array. Closes issue: #2107
dev task |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
For first-time contributors
hacktoberfest
Help contribute during the month of October to participate https://hacktoberfest.digitalocean.com/
WAi-ARIA 1.2 has added a few new roles. Those should be added to axe-core. These roles aren't likely to effect accessibility when they're not supported so I think it's safe to add these right away.
The text was updated successfully, but these errors were encountered: