fix(aria-roles): Add WAI-ARIA 1.2 roles #2544
Conversation
Adds new roles from WAI-ARIA 1.2 spec Closes issue dequelabs#2107
|
Hey there. This is my first time working with a codebase of this size and complexity. I followed the contributing guidelines correctly (I think), only altered the single 1 failing
1) standards.getAriaRolesByType
should return a list of role names by type:
AssertionError: expected [ Array(37) ] to deeply equal [ Array(25) ]
+ expected - actual
[
"article"
- "blockquote"
- "caption"
"cell"
- "code"
"columnheader"
"definition"
- "deletion"
"directory"
"document"
- "emphasis"
"feed"
"figure"
"group"
"heading"
"img"
- "insertion"
"list"
"listitem"
"math"
- "meter"
"none"
"note"
- "paragraph"
"presentation"
"row"
"rowgroup"
"rowheader"
"separator"
- "strong"
- "subscript"
- "superscript"
"table"
"term"
- "time"
"toolbar"
"tooltip"
]
at Context.<anonymous> (standards/get-aria-roles-by-type.js:15:10)I've gone through the get-aria-roles-by-type.js file, which imports from lib/standards/index.js, but I'm at a bit of a loss as how to proceed. It seems like these new roles aren't being added in somewhere else for comparison checks, but like I said I'm a bit green with a project this complex. Could you point me in the right direction to get this fixed for you all? |
|
Sure. The test that is failing takes the roles directly from the standards object. So the fix should just be to add all the roles (looks like you added them all as structure roles) to the list from that test and it should work. |
Adds new roles from WAI-ARIA 1.2 spec to test/commons/standards/get-aria-roles-by-type.js Closes issue dequelabs#2107
Adds the allowedAttrs: ['aria-valuetext'] to the meter role Closes issue dequelabs#2107
There was a problem hiding this comment.
LGTM. But I want @WilcoFiers to look it over really quick make sure this is what he intended.
|
Absolutely, no worries. Thanks so much for the help! |
lib/standards/aria-roles.js
Outdated
| button: { | ||
| type: 'widget', | ||
| allowedAttrs: ['aria-expanded', 'aria-pressed'], | ||
| nameFromContent: true | ||
| }, | ||
| caption: { | ||
| type: 'structure', | ||
| requiredContext: ['figure', 'table', 'grid'] |
There was a problem hiding this comment.
| requiredContext: ['figure', 'table', 'grid'] | |
| requiredContext: ['figure', 'table', 'grid', 'treegrid'] |
Adds treegrid to caption role's requiredContext array. Closes issue: dequelabs#2107
straker
added
the
hacktoberfest
|
@timmybytes Thank you for the pull request! Much appreciated. |
Adds new roles from WAI-ARIA 1.2 to lib/standards/aria-roles.js
Closes issue: #2107
Reviewer checks
Required fields, to be filled out by PR reviewer(s)