Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checks/has-visible-text): work with virtual and serial nodes #2346

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 6, 2020

I noticed that named-from-contents had an exception for table elements to always be considered named from contents. The comment said it was because the implicit role was too over-assertive but I couldn't find any tests in the named-from-contents test suite that showed an example nor could I find a reason in the original pr it was created.

So I removed the exception and just allowed table role to be named from contents. This seemed like a better place for it and still allowed all the tests to pass (without the exception two of our accessible name acceptance tests failed as they required the table element to be named from contents).

Part of issue: #2183

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner July 6, 2020 17:08
@straker straker merged commit 67d2dca into develop Jul 7, 2020
@straker straker deleted the subtree-virtual branch July 7, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants