fix(checks/has-visible-text): work with virtual and serial nodes #2346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
named-from-contents
had an exception fortable
elements to always be considered named from contents. The comment said it was because the implicit role was too over-assertive but I couldn't find any tests in thenamed-from-contents
test suite that showed an example nor could I find a reason in the original pr it was created.So I removed the exception and just allowed
table
role to be named from contents. This seemed like a better place for it and still allowed all the tests to pass (without the exception two of our accessible name acceptance tests failed as they required thetable
element to be named from contents).Part of issue: #2183
Reviewer checks
Required fields, to be filled out by PR reviewer(s)