Merge 2.2.0 #310
Merged
Merge 2.2.0 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure/reset fix
Hotfix frames
Fix color check
Fix/check selector
Add group mappings to the axe-core rules for reporting in Comply V6
fix: pass second label if display:none Approved-by: Wilco Fiers <wilco.fiers@deque.com> Approved-by: Dylan Barrell <dylan@barrell.com>
Needs review support
* fix(test) Update selenium-webdriver
* fix(rule): th-has-data passes on non-text content in td
* feat(grunt): Added dev:no-lint option
fix(gruntfile) Put jshint at the end of the build
* test: reduce console warnings for meta viewport
* feat: pass undefined data for incomplete
* feat: support incomplete by only templating strings
Incomplete objects are handled later in publish-metadata.js
* feat: add explicit incomplete messaging
Incomplete messages come from separate structure instead of templating in pass message
* feat: incorporate incomplete data into checks
* chore: remove unused build task
* test: isolate sticky header test to #fixture
Trying to fix an error on CircleCI, always passed locally
* test: move sticky-header before into it block
Still trying to fix CircleCI
* test: log error for debugging on CircleCI
* test: debug sticky-header check result on CI
* test: clean up debug stuff in test
* fix: simplify extender to use correct Check
I was overthinking it :)
* Feat: Use has-content in td-has-header rule
* Feat: Return cantTell on th-has-data-cells
* feat: move incomplete data API to commons.color
* fix: update language for reasons
* fix: iterate over message objects for templates
Approved-by: Dylan Barrell <dylan@barrell.com>
Approved-by: Wilco Fiers <wilco.fiers@deque.com>
chore: update rule-descriptions
* fix(test) Update selenium-webdriver * fix(rule): th-has-data passes on non-text content in td * Feat: Return cantTell on th-has-data-cells * test: incomplete for contrast in its own directory * test: add message and test for incomplete * chore: make Circle run a newer version of Node Approved-by: Dylan Barrell <dylan@barrell.com>
feat: change audio/video rule to report incomplete Closes #285 Approved-by: Wilco Fiers <wilco.fiers@deque.com>
Mobile tests for axe-core
* test: add mobile chrome to webdriver tests
* test: fix font-size color contrast failures
* test: add meta viewport tag to prevent scaling
Test failures were caused by content resizing in the mobile browser after being dynamically injected by the test runner. user-scalable=no also fixed test failures at the iPhone 5 viewport in the test harness. The same test passed at that viewport outside of our test suite.
fix: pass color-contrast of child inside disabled button
* fix: pass child of disabled button
Closes #250
* fix: use recursion and support aria-disabled
* feat: add support for disabled fieldsets
* feat: add support for disabled label descendants
Approved-by: Wilco Fiers <wilco.fiers@deque.com>
Approved-by: Dylan Barrell <dylan@barrell.com>
… optimally suited role
* Add configuration options: - `iframes`: if false, only collect results from top frame - `elementRef`: if true, return live element references for results from top frame - `noSelectors`: if true, omit `target` for results from top frame. * Address review comments * Add tests in run-rules.js and run.js and invert sense of 'noSelectors' to 'selectors'
Approved-by: Marcy Sutton <marcy.sutton@deque.com> Approved-by: Wilco Fiers <wilco.fiers@deque.com>
fix: Properly translate check messages Closes https://dequesrc.atlassian.net/browse/WWD-675 Approved-by: Marcy Sutton <marcy.sutton@deque.com>
|
Wilco Fiers seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@marcysutton in general this looks good but it looks to me like:
|
dylanb
requested changes
Apr 26, 2017
|
@marcysutton Also looks like the circle.yml file got lost somehow |
|
I excluded circle.yml since we were using Travis, I'll replace it when we make the switch. Opening an issue for that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge from Bitbucket:develop to Github:master for the 2.2.0 release. Not sure why it's showing a bunch of old commits, since we merged them long ago.