Skip to content

Commit

Permalink
fix: CRD loading: trim group suffix from CRD name (#3045)
Browse files Browse the repository at this point in the history
* Fix CRD loading: trim group suffix from CRD name

* gofmt
  • Loading branch information
ivant authored Feb 2, 2025
1 parent 18b2ada commit e27e293
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions internal/dao/registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,13 @@ func loadCRDs(f Factory, m ResourceMetas) {
var meta metav1.APIResource
meta.Kind = crd.Spec.Names.Kind
meta.Group = crd.Spec.Group
// Since CRD names are cluster scoped they need to be unique, however, it is allowed
// to have the CRDs with the same names in different groups. Because of that, the
// returned `crd.Name` values have the group as a suffix, for example
// "ciliumnetworkpolicies.cilium.io".
//
// `Name` field of `meta/v1/APIResource` is supposed to be the plural name of the
// resource, without the group. Because of that we need to trim the group suffix.
meta.Name = strings.TrimSuffix(crd.Name, "."+meta.Group)

meta.SingularName = crd.Spec.Names.Singular
Expand Down

0 comments on commit e27e293

Please sign in to comment.