Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CRD loading: trim group suffix from CRD name #3045

Merged
merged 3 commits into from
Feb 2, 2025

Conversation

ivant
Copy link
Contributor

@ivant ivant commented Dec 29, 2024

This fixes #3044.

@ivant
Copy link
Contributor Author

ivant commented Dec 29, 2024

Also possibly fixes #3025, #2936.

@derailed
Copy link
Owner

@ivant Nice catch! Thank you Ivan. It looks like there is a fmt issue on this update. Could you address it?

@derailed derailed added bug Something isn't working needs-tlc Pr needs additional updates labels Jan 12, 2025
@ivant
Copy link
Contributor Author

ivant commented Jan 20, 2025

@ivant Nice catch! Thank you Ivan. It looks like there is a fmt issue on this update. Could you address it?

Done! Thank you!

@derailed derailed merged commit e27e293 into derailed:master Feb 2, 2025
2 checks passed
@ivant ivant deleted the fix-3044 branch February 4, 2025 18:54
@derailed derailed mentioned this pull request Feb 15, 2025
thorbenbelow pushed a commit to thorbenbelow/k9s that referenced this pull request Feb 17, 2025
* Fix CRD loading: trim group suffix from CRD name

* gofmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-tlc Pr needs additional updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRDs are loaded incorrectly into metadata registry, cause sporadic "Jump Owner" issues
2 participants