Fix Mark-Range command: ensure that NS Favorite doesn't exceed the limit #2881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1191
While the root cause of the issue, where the number of favorites exceeds the limit, is still unknown, I believe this is a nice check to have, when validating namespaces. And as pointed out in the #1191, it fixes the issue with mark-range not working and instead showing in the tooltip the namespace that exceeds the limit.
MaxFavoritesNS
to cover all 0-9 numbers.Manually validated that configs are updating properly and the number of favorites doesn't exceed the limit.
Tested on MacOs.