Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fluctuation of execute time when re-executing a cell #112

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Fix fluctuation of execute time when re-executing a cell #112

merged 5 commits into from
Feb 3, 2024

Conversation

krassowski
Copy link
Collaborator

References

Fixes #111

Code changes

  1. Un-skipping test for kernel failure, which requires testing against JupyterLab 4.1 (RC 1) and updating galata and playwright versions (5082d11)
  2. Adds an integration test (bb80d3f) which fails prior to the fix with: 
    Error: locator.evaluate: Non-increasing time delta seen, from 8520ms to 512ms in 2 update
  3. Fixes the issue by correcting the metadata check (00b1e8e)
  4. Minor linting/comment fixes (00b1e8e, a5fd189)

User-facing changes

Before After
before after

@krassowski krassowski added the bug Something isn't working label Feb 2, 2024
@krassowski krassowski changed the title Fix double timing Fix fluctuation of execute time when re-executing a cell Feb 2, 2024
@krassowski krassowski mentioned this pull request Feb 2, 2024
Closed
@mlucool mlucool merged commit 08943df into deshaw:master Feb 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time in cell seems to fluctuate a span of twenty minutes multiple times a second
2 participants
@krassowski @mlucool