Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time in cell seems to fluctuate a span of twenty minutes multiple times a second #111

Closed
jabbera opened this issue Jan 31, 2024 · 6 comments · Fixed by #112
Closed

Time in cell seems to fluctuate a span of twenty minutes multiple times a second #111

jabbera opened this issue Jan 31, 2024 · 6 comments · Fixed by #112

Comments

@jabbera
Copy link

jabbera commented Jan 31, 2024

Sorry of the description is odd, but I didn't know how to explain it.

Recording.2024-01-30.194718.mp4

jupyterlab_execute_time 3.1.0 pyhd8ed1ab_0 conda-forge

@krassowski
Copy link
Collaborator

@jabbera thanks for opening the issue. I saw something similar in the past when the kernel crashes (#84) and I believe that was already fixed in #100 but the fix is only effective in JupyterLab 4.1+ (currently in release candidate phase). Which version of JupyterLab did you use?

In general, can you provide reproduction instructions, or does it happen sporadically without a clear trigger?

Finally, do you have windowing enabled in JupyterLab settings (Settings → Settings Editor → Notebook → Windowing mode, at the very bottom)?

FYI, there is a newer version (3.1.1) available.

@jabbera
Copy link
Author

jabbera commented Jan 31, 2024

JupyterLab 4.0.10
I haven't been able to pin down the cause but it is happening during a long running memory intensive op. There is the potential the kernel crashed without providing feedback.
Windowing mode is set to Defer

I'm happy to wait till 4.1 comes out and validate that the issue goes away!

@mlucool
Copy link
Member

mlucool commented Feb 1, 2024

I am seeing this with defer + 4.1.0rc1

@krassowski
Copy link
Collaborator

I can reproduce when re-running a cell which was already running. There is an error in the console:

ExecuteTimeWidget.ts:311 Uncaught TypeError: Cannot read properties of undefined (reading 'execution_failed')
    at ExecuteTimeWidget.ts:311:34

so this is a regression from the PR I mentioned. I will open a PR to fix it.

@krassowski
Copy link
Collaborator

@jabbera if you would like to test the fix from #112, you can download extension-artifacts from the associated CI build and install the patched version using pip.

@mlucool
Copy link
Member

mlucool commented Feb 16, 2024

This was released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants