Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use execution failure timing information #100

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Use execution failure timing information #100

merged 3 commits into from
Oct 31, 2023

Conversation

krassowski
Copy link
Collaborator

References

Fixes #84

Depends on jupyterlab/jupyterlab#15285 which targets JupyterLab 4.1

Code changes

  • Aborts updates of live execution when new key execution_failed is detected in cell timing metadata
  • Adds new status to display when cell execution failed due to kernel restart

User-facing changes

Before After
execute-before execute-after

@krassowski krassowski added the bug Something isn't working label Oct 21, 2023
@krassowski
Copy link
Collaborator Author

Marking as ready for review since jupyterlab/jupyterlab#15285 got merged.

@krassowski krassowski marked this pull request as ready for review October 30, 2023 12:52
mlucool
mlucool approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mlucool mlucool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs please

@krassowski krassowski merged commit d9b8ea0 into deshaw:master Oct 31, 2023
2 checks passed
@krassowski krassowski mentioned this pull request Nov 4, 2023
Merged
@krassowski krassowski mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlucool mlucool mlucool approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

execute-time seems to keep running after the jupyter kernel dies.
2 participants
@krassowski @mlucool