Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute-time seems to keep running after the jupyter kernel dies. #84

Closed
dharhas opened this issue Apr 14, 2023 · 4 comments · Fixed by #100
Closed

execute-time seems to keep running after the jupyter kernel dies. #84

dharhas opened this issue Apr 14, 2023 · 4 comments · Fixed by #100

Comments

@dharhas
Copy link

dharhas commented Apr 14, 2023

No sure if this is jupyterhub specific or a general issue. But if the jupyter-kernel dies for any reason the time ticker keeps going and the cell looks like it is still running. The asterisk at the side of the cell also still shows the cell as running. Has anyone else experienced this?

@krassowski
Copy link
Collaborator

krassowski commented Apr 17, 2023

Yes, I experienced this a few times. I suspect that the underlying issue is the same as in jupyterlab/jupyterlab#13780 which I fixed in jupyterlab/jupyterlab#13832. Shortly, when kernel gets killed (e.g. by OOM killer) it does not send the message saying that it finished/shut down (well, it can't - it's dead); instead we can listen to restarting message which indicates that a new kernel is being spawn in place of the old one and use it to mark execution as finished.

@mlucool
Copy link
Member

mlucool commented Apr 17, 2023

we can listen to restarting message which indicates that a new kernel is being spawn in place of the old one and use it to mark execution as finished

We may just want to mark this as failed not finished in some way. Other than that, I agree

@mlucool
Copy link
Member

mlucool commented Aug 2, 2023

@krassowski is this still an issue? If so, lets fix it

@krassowski
Copy link
Collaborator

Yes.

This also happens when cutting and pasting, or when dragging cells while the execution is running:

keeps-running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants