Store information about execution failure timing #15285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
deshaw/jupyterlab-execute-time#84
Code changes
Adds
execution_failed
toexecution
metadata when execution is aborted due to kernel restart/when kernel dies.Questions:
execution_failed
the best name? the other existing keys are derived from message channel/name/status:jupyterlab/packages/cells/test/widget.spec.ts
Lines 905 to 911 in 897418f
User-facing changes
Users of
jupyterlab-execute-time
will be able to see when the execution failed/after how much time rather than incorrectly seeing the execution timer continue.Backwards-incompatible changes
None