Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved modeling of galaxies with broad+narrow line-emission #142

Merged
merged 10 commits into from
Aug 2, 2023
Merged

improved modeling of galaxies with broad+narrow line-emission #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ee22504
begin working on #118
moustakas Aug 1, 2023
af23fc5
working version
moustakas Aug 1, 2023
8f73a73
update data model documentation
moustakas Aug 1, 2023
3533cb1
bug
moustakas Aug 1, 2023
61be855
drop too-narrow balmer lines and if sigma_broad<sigma_narrow
moustakas Aug 1, 2023
36a30dc
if amp==0, set sigma,vshift = 0, too
moustakas Aug 1, 2023
7e0aa40
out-of-range reference lines should also get zeroed out
moustakas Aug 1, 2023
9d15d5f
address #130; tests find a 30%-40% speed-up when fitting single objec…
moustakas Aug 1, 2023
db857e9
update change log; a few other small fixes
moustakas Aug 2, 2023
8db4dbd
reduced wavelength padding from 5 to 2.5 A to address #111
moustakas Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/changes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,16 @@ Change Log
* Switch from (deprecated) ``pkg_resources`` to ``importlib``.
* Updated documentation (data model) and several non-negligible speed-ups.

* Improved modeling of galaxies with broad+narrow line-emission [`PR #142`_]:

.. _`PR #115`: https://github.com/desihub/fastspecfit/pull/115
.. _`PR #116`: https://github.com/desihub/fastspecfit/pull/116
.. _`PR #120`: https://github.com/desihub/fastspecfit/pull/120
.. _`PR #132`: https://github.com/desihub/fastspecfit/pull/132
.. _`PR #135`: https://github.com/desihub/fastspecfit/pull/135
.. _`PR #136`: https://github.com/desihub/fastspecfit/pull/136
.. _`PR #137`: https://github.com/desihub/fastspecfit/pull/137
.. _`PR #142`: https://github.com/desihub/fastspecfit/pull/142

2.1.2 (2023-04-01)
------------------
Expand Down
5 changes: 3 additions & 2 deletions doc/fastspec.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,9 @@ Name Type Units Descript
FHBETA_CONT float32 1e-17 erg / (Angstrom cm2 s) Continuum flux at 4862.683 A in the rest-frame.
FOIII_5007_CONT float32 1e-17 erg / (Angstrom cm2 s) Continuum flux at 5008.239 A in the rest-frame.
FHALPHA_CONT float32 1e-17 erg / (Angstrom cm2 s) Continuum flux at 6564.613 A in the rest-frame.
RCHI2_LINE float32 Reduced chi-squared of an emission-line model fit.
DELTA_LINERCHI2 float32 Difference in the reduced chi-squared values between an emission-line model with narrow lines only and a model with both broad and narrow lines.
RCHI2_LINE float32 Reduced chi-squared of the emission-line model fit.
DELTA_LINECHI2 float32 Chi-squared difference between an emission-line model without and with broad lines.
DELTA_LINENDOF int32 Difference in the degrees of freedom between an emission-line model without and with broad lines.
APERCORR float32 Median aperture correction factor.
APERCORR_G float32 Median aperture correction factor measured in the g-band.
APERCORR_R float32 Median aperture correction factor measured in the r-band.
Expand Down
Loading
Loading