add 386, arm, and arm64 to ubuntu buildscripts #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofficialgman
force-pushed
the
local-arm-builds
branch
from
5a46bd6 to
32fea1a
Compare
theofficialgman
force-pushed
the
local-arm-builds
branch
from
32fea1a to
25e63d8
Compare
|
@shiftkey LGTM you can see I also have a separate branch on my fork where I am personally using the always free tier of the Oracle Cloud services with Ampere ARM A1 processors to build with a github self hosted runner on a bionic arm64 image https://www.oracle.com/cloud/free/ I don't see why the desktop team can not do the same. |
theofficialgman
force-pushed
the
local-arm-builds
branch
from
25e63d8 to
b24e7d5
Compare
theofficialgman
force-pushed
the
local-arm-builds
branch
from
b24e7d5 to
153ab50
Compare
theofficialgman
force-pushed
the
local-arm-builds
branch
3 times, most recently
from
8c45bbe to
00d945f
Compare
|
@tidy-dev @shiftkey @sergiou87 @niik I am once again requesting that this be merged it is a non-breaking change to your CI and makes building on x86, arm, and arm64 linux work out of the box without having to constantly rebase this patch on master |
added arm, and arm64 as acceptable TARGET_ARCH options correct update-git-lfs.ts to update linux x86, arm64, and arm transition to use significantly better naming scheme in preparation for extension to multiple more architectures
theofficialgman
force-pushed
the
local-arm-builds
branch
from
00d945f to
b04f6a7
Compare
|
closing in favor of a new cross compiling PR that you WILL merge |
This was referenced Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current use of 64 and 32 in github actions is unaffected and will function as before
added arm, and arm64 as acceptable TARGET_ARCH options
this allows for making local builds of dugite-native on arm/arm64 hardware using the same buildscripts used in the github actions.
future changes may allow for building through github actions as well using cross compilation (or self hosted runner, see below)