add ARM64, ARM32, and x86 Linux to update-embedded-git #522
Conversation
|
sorry I don't want to have to do this but I am going to have to start doing weekly pings to the relavent devs so that this can be merged. as seen in the above comment this is a highely requested feature, closes many issues, and is a blocker for other projects LGTM! @shiftkey @sergiou87 @niik |
|
Hey @theofficialgman! I will try to find some time for this. Sorry we haven't been very responsive, we're a very small team 😓 First we need to get desktop/dugite-native#414 merged, then continue with this one. |
|
@sergiou87 no worries. I appreciate the response. I know that some of you probably work on multiple projects so I wouldn't want this to get lost. |
theofficialgman
changed the title
|
@theofficialgman would you mind adding actions to the remaining OS + arch combinations (Linux x86/arm/arm64 and macOS arm64)? Other than that I think everything in this PR looks great 😄 |
|
|
oh nevermind I see what you requested. I don't think I can do that because arm64 is not the native architecture of the github runner. so the yarn test will fail due to not being able to run any native binaries https://github.com/desktop/dugite/blob/main/.github/workflows/ci.yml#L56 |
|
Sigh… you're right, I always forget about that detail 🤦♂️ |
|
I hope a new release comes soon with these changes. |
Spiritual successor to desktop/dugite-native#330
Fixes desktop/dugite-native#315
Replacement for desktop/dugite-native#368
Closes desktop/dugite-native#158
Closes #521
progress for shiftkey/desktop#251
in tandum with desktop/dugite-native#414
@desktop I have done your job for you, now LGTM!