Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 back #330

Closed
wants to merge 3 commits into from
Closed

Add arm64 back #330

wants to merge 3 commits into from

Conversation

AaronDewes
Copy link

@AaronDewes AaronDewes commented Jun 30, 2020

This adds ARM64 again. Many people wanted this in Desktop, and this would help to add it. I also made it a bit faster.

Changes to speed up ARM64

  • Use two parallel make jobs
  • Compile directly on ARM64 instead of cross-compiling
  • Don't use Docker anymore
  • Use ccache

@niik
Copy link
Member

niik commented Jun 30, 2020

Many people wanted this in Desktop

Hey @AaronDewes 👋 Could you provide some links to this? I was aware of the initiative to support ARM64 on Windows (desktop/desktop#9034) but the arm64 work we removed in #315 was specifically for Linux which isn't a supported platform for GitHub Desktop at the moment

@AaronDewes
Copy link
Author

AaronDewes commented Jun 30, 2020

It's at the Linux fork: shiftkey/desktop#251

@AaronDewes
Copy link
Author

It should now build directly on arm64, so it doesn't cross-compile anymore, which should speed up the build.

@AaronDewes AaronDewes force-pushed the arm64-again branch 2 times, most recently from cf2570d to b4b03cf Compare June 30, 2020 13:24
@AaronDewes
Copy link
Author

The macOS builds are failing, but I don't think it's caused by this PR.

@AaronDewes
Copy link
Author

I don't know why Ubuntu and macOS builds are failing, macOS just seems to clone from an invalid repo: https://travis-ci.org/github/desktop/dugite-native/jobs/703526404#L860.

@AaronDewes
Copy link
Author

AaronDewes commented Jun 30, 2020

ARM64 still takes a bit longer, but not 10 minutes anymore. Ubuntu builds are fixed now.

@AaronDewes AaronDewes changed the title Arm64 again Add arm64 back Jul 1, 2020
@AaronDewes
Copy link
Author

I've rebased it now. The arm64 build takes about 5 minutes now, macOS is still failing for some reasons.

@AaronDewes
Copy link
Author

Seems impossible again now, GitHub actions has no arm64 support and it would be really slow again

@theofficialgman
Copy link
Contributor

github actions has self hosted arm/arm64 support... is that not an option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants