-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 back #330
Add arm64 back #330
Conversation
Hey @AaronDewes 👋 Could you provide some links to this? I was aware of the initiative to support ARM64 on Windows (desktop/desktop#9034) but the arm64 work we removed in #315 was specifically for Linux which isn't a supported platform for GitHub Desktop at the moment |
It's at the Linux fork: shiftkey/desktop#251 |
It should now build directly on arm64, so it doesn't cross-compile anymore, which should speed up the build. |
cf2570d
to
b4b03cf
Compare
The macOS builds are failing, but I don't think it's caused by this PR. |
I don't know why Ubuntu and macOS builds are failing, macOS just seems to clone from an invalid repo: https://travis-ci.org/github/desktop/dugite-native/jobs/703526404#L860. |
ARM64 still takes a bit longer, but not 10 minutes anymore. Ubuntu builds are fixed now. |
I've rebased it now. The arm64 build takes about 5 minutes now, macOS is still failing for some reasons. |
Seems impossible again now, GitHub actions has no arm64 support and it would be really slow again |
github actions has self hosted arm/arm64 support... is that not an option? |
This adds ARM64 again. Many people wanted this in Desktop, and this would help to add it. I also made it a bit faster.
Changes to speed up ARM64