Remove support for arm64 going forward #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niik
added a commit
that referenced
this pull request
Jan 13, 2020
niik
added a commit
to desktop/dugite
that referenced
this pull request
Jan 14, 2020
This was referenced Apr 3, 2020
Closed
This was referenced Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes tooling and configuration for building and distributing
dugite-nativefor arm64 architectures. All previously released builds for arm64 architectures will remain.Motivation
The CI process for arm64 builds is much slower than the other platforms (more than an extra ten minutes in most cases). This is especially problematic for security vulnerability releases that are time-sensitive (since this project is a dependency of Desktop). Desktop does not use the arm64 distribution of dugite-native and we aren't aware of any significant projects that do.
Notes
If at some point in the future we need to support arm64 architecture again, this PR can be reverted to bring this work back.