-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reactions events #144
Comments
I will good for the explorer to show the transactions as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
Currently when a user adds or removes a reaction to a post, the following event is emitted:
As we can see, the event contains only the associated short code of the reaction that is added to the post. While this might be ok, it presents two problems:
If the user adds ":smile:" as a reaction, the event will instead contain
:smile:
, which might be confusing to watch from an external point of view cause it doesn't tell where that code comes from and where the value has gone.If the user needs to have both the added value as well as the added shortcode, he will need to parse the event and the message, which is pretty strange.
Solution
In order to improve the usability of such events, what I suggest we should do is adding another attribute to both the event emitted when processing
MsgAddPostReaction
and the one emitted when processingMsgRemovePostReaction
so that both contain:shortcode
of the added reactionvalue
(either emoji or URI) of the added reaction. This can be read from the store (if already registered) or from the value (if an emoji).The text was updated successfully, but these errors were encountered: