Generic reactions improvements #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leobragaz
added
kind/enhancement
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
- Coverage 82.64% 82.61% -0.04%
==========================================
Files 56 56
Lines 2374 2398 +24
==========================================
+ Hits 1962 1981 +19
- Misses 355 357 +2
- Partials 57 60 +3 |
…generic-reactions-improvements � Conflicts: � CHANGELOG.md
…generic-reactions-improvements � Conflicts: � x/posts/internal/types/msgs/msg_reactions.go � x/posts/internal/types/msgs/msgs_post_reactions.go � x/posts/internal/types/msgs/msgs_post_reactions_test.go
RiccardoM
suggested changes
May 6, 2020
x/posts/internal/keeper/handler.go
Outdated
Comment on lines
152
to
169
| if emojiReact, err := emoji.LookupEmoji(parsedReaction); err == nil { | ||
| reactionShortcode = emojiReact.Shortcodes[0] | ||
| reactionValue = emojiReact.Value | ||
| } else { //if not, check if the shortcode is related to any emoji | ||
| emo, err := emoji.LookupEmojiByCode(parsedReaction) | ||
| if err != nil { // if no emoji is related to it, check if the shortcode has been registered before | ||
| regReaction, exist := keeper.GetRegisteredReaction(ctx, parsedReaction, post.Subspace) | ||
| if !exist { // if it has not been registered yet, no one can use it to react to the post | ||
| return nil, sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, | ||
| fmt.Sprintf("reaction with short code %s isn't registered yet and can't be used to react to the post with ID %s and subspace %s, please register it before use", | ||
| parsedReaction, post.PostID, post.Subspace)) | ||
| } | ||
| reactionValue = regReaction.Value | ||
| reactionShortcode = regReaction.ShortCode | ||
| } else { | ||
| reactionValue = emo.Value | ||
| reactionShortcode = emo.Shortcodes[0] | ||
| } |
There was a problem hiding this comment.
I'm not a big fan of this piece of code's structure. I think it can be improve by doing something like
if emojiReact, err := emoji.LookupEmoji(parsedReaction); err == nil {
// The reaction was an emoji Unicode character
} else if emojiReact, err := emoji.LookupEmojiByCode(parsedReaction); err == nil {
// The reaction was an emoji shotcode
} else {
// The reaction was a shortcode that should be registered
}I think it would be more easy to read. Also, since this entire piece of code is used as well inside the handleMsgRemovePostReaction, I would avoid duplicating it. To do this, we should move it into an external function.
There was a problem hiding this comment.
yeah I was not so conviced as well but I couldn’t think a better way to do that in that moment so I was hoping for some advice from you!
…vements' into leonardo/generic-reactions-improvements # Conflicts: # x/posts/internal/types/msgs/msgs_post_reactions.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the problems discussed in issues #144 #145 #147.
Closes #144.
Closes #145.
Closes #147.
Checklist
CHANGELOG.mdfile.Files changedin the Github PR explorer.