PoS Add QC fields to block header schema

[tholonious]

No description provided.

[tholonious]

Current dependencies on/for this PR:

• feature/pos-messaging-schema
  • PR PoS Add P2P vote and timeout messages #555
    • PR PoS Add QC fields to block header schema #558 👈
      • PR PoS Implement Bitset data structure #564
        • PR PoS Add Bitset to messaging schema #565
          • PR PoS Simplify PublicKey field names in P2P messages #566
            • PR PoS Add BLS public key and signature to BlockProducerInfo #567
              • PR PoS Add ProposedInView field to block header #568
                • PR PoS Compress uint64 fields in MsgDeSoHeader version 2 #569

This comment was auto-generated by Graphite.

[AeonSw4n]

Yeah looks good! Only minor stuff. I'm setting "Request changes" because my local tests weren't passing for:

• TestHeaderConversionAndReadWriteMessage
• TestHeaderBundleSerialization

Can you double-check if these are passing for you, and I'll approve?

[tholonious]

Yeah looks good! Only minor stuff. I'm setting "Request changes" because my local tests weren't passing for:

• TestHeaderConversionAndReadWriteMessage
• TestHeaderBundleSerialization

Can you double-check if these are passing for you, and I'll approve?

@AeonSw4n, you need to add -tags relic when compiling core to run all unit tests locally. The two tests above both run MsgDeSoHeader serialization/deserialization with the PoS QC fields. Both tests pass for me locally, and pass in CI.

[AeonSw4n]

All passed this time!