Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoS Add BLS public key and signature to BlockProducerInfo #567

Merged
merged 8 commits into from
Jun 28, 2023
Merged

PoS Add BLS public key and signature to BlockProducerInfo #567

merged 8 commits into from
Jun 28, 2023

Conversation

tholonious
Copy link
Contributor

@tholonious tholonious commented Jun 27, 2023 •
edited
Loading

This PR makes three changes:

  1. It migrates the existing ECDSA PublicKey fields in the BlockProducerInfo from a byte slice to the strongly typed PublicKey type
  2. It introduces versioning to BlockProducerInfo, with a byte encoder and decoder that support the new versioned schema. The existing un-versioned schema is still supported by the legacy encoder and decoder
  3. It adds BLS VotingPUblicKey and VotePartialSignature fields to BlockProducerInfo that are populated in newly created Version=1 format

This was referenced Jun 27, 2023
Merged
Merged
Merged
Merged
Merged
@tholonious
Copy link
Contributor Author

tholonious commented Jun 27, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Base automatically changed from sa/simplify_public_key_field_names_for_vote_and_timeout_msg_types to feature/pos-messaging-schema June 27, 2023 17:29
@tholonious tholonious force-pushed the sa/add-bls-pk-and-signature-to-BlockProducerInfo branch from c2f14ab to 5c55de0 Compare June 27, 2023 19:07
@tholonious tholonious marked this pull request as ready for review June 27, 2023 19:25
@tholonious tholonious requested a review from a team as a code owner June 27, 2023 19:25
@tholonious tholonious mentioned this pull request Jun 27, 2023
Merged
lazynina
lazynina requested changes Jun 27, 2023
View reviewed changes
lib/network.go Outdated Show resolved Hide resolved
lib/network.go Show resolved Hide resolved
lib/network.go Outdated Show resolved Hide resolved
lib/network.go Outdated Show resolved Hide resolved
lib/network.go Outdated Show resolved Hide resolved
@tholonious tholonious mentioned this pull request Jun 27, 2023
Merged
@tholonious tholonious changed the title PoS Add BLS PK and signature to BlockProducerInfo PoS Add BLS public key and signature to BlockProducerInfo Jun 27, 2023
AeonSw4n
AeonSw4n suggested changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@AeonSw4n AeonSw4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just have one comment regarding the forward-compatibility of BlockProducerInfo.Version.

lib/network.go Show resolved Hide resolved
@tholonious tholonious requested a review from AeonSw4n June 28, 2023 15:04
@tholonious tholonious merged commit 3e21ba2 into feature/pos-messaging-schema Jun 28, 2023
@tholonious tholonious deleted the sa/add-bls-pk-and-signature-to-BlockProducerInfo branch June 28, 2023 15:12
tholonious added a commit that referenced this pull request Jul 5, 2023
@tholonious
Revert BLS public key and signature in BlockProducerInfo (#567)
4d0510a
tholonious added a commit that referenced this pull request Jul 5, 2023
@tholonious
Revert BLS public key and signature in BlockProducerInfo (#567)
273db55
tholonious added a commit that referenced this pull request Jul 5, 2023
@tholonious
Revert BLS public key and signature in BlockProducerInfo (#567) (#576)
9b1a8b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazynina lazynina lazynina approved these changes

@AeonSw4n AeonSw4n Awaiting requested review from AeonSw4n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tholonious @AeonSw4n @lazynina