-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoS Add BLS public key and signature to BlockProducerInfo #567
Merged
tholonious
merged 8 commits into
feature/pos-messaging-schema
from
sa/add-bls-pk-and-signature-to-BlockProducerInfo
Jun 28, 2023
Merged
PoS Add BLS public key and signature to BlockProducerInfo #567
tholonious
merged 8 commits into
feature/pos-messaging-schema
from
sa/add-bls-pk-and-signature-to-BlockProducerInfo
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2023
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Base automatically changed from
sa/simplify_public_key_field_names_for_vote_and_timeout_msg_types
to
feature/pos-messaging-schema
June 27, 2023 17:29
tholonious
force-pushed
the
sa/add-bls-pk-and-signature-to-BlockProducerInfo
branch
from
June 27, 2023 19:07
c2f14ab
to
5c55de0
Compare
lazynina
requested changes
Jun 27, 2023
lazynina
approved these changes
Jun 27, 2023
tholonious
changed the title
PoS Add BLS PK and signature to BlockProducerInfo
PoS Add BLS public key and signature to BlockProducerInfo
Jun 27, 2023
AeonSw4n
suggested changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I just have one comment regarding the forward-compatibility of BlockProducerInfo.Version.
lazynina
approved these changes
Jun 28, 2023
tholonious
added a commit
that referenced
this pull request
Jul 5, 2023
tholonious
added a commit
that referenced
this pull request
Jul 5, 2023
tholonious
added a commit
that referenced
this pull request
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three changes:
PublicKey
type