PoS Mempool Transaction Register #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f8e6855.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
AeonSw4n
changed the title
Closed
tholonious
requested changes
Jun 22, 2023
tholonious
reviewed
Jun 22, 2023
lazynina
requested changes
Jun 27, 2023
lazynina
reviewed
Jun 27, 2023
tholonious
requested changes
Jun 28, 2023
tholonious
reviewed
Jul 3, 2023
tholonious
requested changes
Jul 3, 2023
|
Alright @AeonSw4n, one last round. Everything LGTM at a high level. Main comments are for the FeeTimeIterator. If you can bullet-proof it a bit and add more unit tests around its edge cases, it'll make everything quite more resilient. |
tholonious
reviewed
Jul 3, 2023
lazynina
reviewed
Jul 5, 2023
lazynina
approved these changes
Jul 5, 2023
tholonious
reviewed
Jul 5, 2023
Base automatically changed from
p/pos-mempool-data-structures
to
feature/pos-mempool
July 5, 2023 23:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.